Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1425093006: Revert "Switch profiler from isolates to threads" (Closed)

Created:
5 years, 1 month ago by Bill Hesse
Modified:
5 years, 1 month ago
Reviewers:
mit, Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Switch profiler from isolates to threads" Reverts commit 6365c27f81c02605ac9d9ec879022ceacc0bdea8 and commit 8b9ed6cfb3cfb6ee66acdc3b18c2cea476563086. They are causing flaky timeouts (hangs) on all vm cc tests on all Windows vm bots. R=mit@google.com Committed: https://github.com/dart-lang/sdk/commit/cc4a5d2e7c06a4d9b577afae7a3ae059026cb201

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+555 lines, -233 lines) Patch
M runtime/bin/dartutils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/include/dart_api.h View 1 chunk +4 lines, -15 lines 0 comments Download
M runtime/tests/vm/vm.status View 1 chunk +17 lines, -0 lines 0 comments Download
M runtime/vm/dart.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +12 lines, -8 lines 0 comments Download
M runtime/vm/debugger.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/isolate.h View 2 chunks +18 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 3 chunks +58 lines, -0 lines 0 comments Download
M runtime/vm/message_handler.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/profiler.h View 1 chunk +38 lines, -4 lines 0 comments Download
M runtime/vm/profiler.cc View 15 chunks +176 lines, -41 lines 0 comments Download
M runtime/vm/profiler_service.cc View 4 chunks +32 lines, -15 lines 0 comments Download
M runtime/vm/profiler_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stub_code.h View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/stub_code.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M runtime/vm/thread.h View 6 chunks +9 lines, -21 lines 0 comments Download
M runtime/vm/thread.cc View 7 chunks +26 lines, -52 lines 0 comments Download
M runtime/vm/thread_interrupter.h View 3 chunks +9 lines, -1 line 0 comments Download
M runtime/vm/thread_interrupter.cc View 4 chunks +39 lines, -36 lines 0 comments Download
M runtime/vm/thread_interrupter_android.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M runtime/vm/thread_interrupter_linux.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M runtime/vm/thread_interrupter_macos.cc View 3 chunks +8 lines, -5 lines 0 comments Download
A runtime/vm/thread_interrupter_test.cc View 1 chunk +66 lines, -0 lines 0 comments Download
M runtime/vm/thread_interrupter_win.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M runtime/vm/thread_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/vm_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bill Hesse
5 years, 1 month ago (2015-11-03 09:34:47 UTC) #2
mit
On 2015/11/03 09:34:47, Bill Hesse wrote: lgtm: https://screenshot.googleplex.com/OWps1WY2psL
5 years, 1 month ago (2015-11-03 09:38:55 UTC) #3
Bill Hesse
5 years, 1 month ago (2015-11-03 09:43:00 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
cc4a5d2e7c06a4d9b577afae7a3ae059026cb201 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698