Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 1425093006: Revert "Switch profiler from isolates to threads" (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.cc
diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc
index 6e668c84ffb555a4adbea9a2016dcf1beaba48fd..8ee0c5dc52f7611ff02fa23ed1bd11b4e67077d1 100644
--- a/runtime/vm/dart_api_impl.cc
+++ b/runtime/vm/dart_api_impl.cc
@@ -1464,21 +1464,25 @@ DART_EXPORT void Dart_EnterIsolate(Dart_Isolate isolate) {
}
-DART_EXPORT void Dart_ThreadDisableProfiling() {
- Thread* T = Thread::Current();
- if (T == NULL) {
+DART_EXPORT void Dart_IsolateBlocked() {
+ Isolate* isolate = Isolate::Current();
+ CHECK_ISOLATE(isolate);
+ IsolateProfilerData* profiler_data = isolate->profiler_data();
+ if (profiler_data == NULL) {
return;
}
- T->DisableThreadInterrupts();
+ profiler_data->Block();
}
-DART_EXPORT void Dart_ThreadEnableProfiling() {
- Thread* T = Thread::Current();
- if (T == NULL) {
+DART_EXPORT void Dart_IsolateUnblocked() {
+ Isolate* isolate = Isolate::Current();
+ CHECK_ISOLATE(isolate);
+ IsolateProfilerData* profiler_data = isolate->profiler_data();
+ if (profiler_data == NULL) {
return;
}
- T->EnableThreadInterrupts();
+ profiler_data->Unblock();
}
« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698