Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Side by Side Diff: runtime/vm/thread_interrupter_macos.cc

Issue 1425093006: Revert "Switch profiler from isolates to threads" (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/thread_interrupter_linux.cc ('k') | runtime/vm/thread_interrupter_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/globals.h" 5 #include "platform/globals.h"
6 #if defined(TARGET_OS_MACOS) 6 #if defined(TARGET_OS_MACOS)
7 7
8 #include <errno.h> // NOLINT
9
10 #include "vm/flags.h" 8 #include "vm/flags.h"
11 #include "vm/os.h" 9 #include "vm/os.h"
12 #include "vm/profiler.h"
13 #include "vm/signal_handler.h" 10 #include "vm/signal_handler.h"
14 #include "vm/thread_interrupter.h" 11 #include "vm/thread_interrupter.h"
15 12
16 namespace dart { 13 namespace dart {
17 14
18 DECLARE_FLAG(bool, thread_interrupter); 15 DECLARE_FLAG(bool, thread_interrupter);
19 DECLARE_FLAG(bool, trace_thread_interrupter); 16 DECLARE_FLAG(bool, trace_thread_interrupter);
20 17
21 class ThreadInterrupterMacOS : public AllStatic { 18 class ThreadInterrupterMacOS : public AllStatic {
22 public: 19 public:
23 static void ThreadInterruptSignalHandler(int signal, siginfo_t* info, 20 static void ThreadInterruptSignalHandler(int signal, siginfo_t* info,
24 void* context_) { 21 void* context_) {
25 if (signal != SIGPROF) { 22 if (signal != SIGPROF) {
26 return; 23 return;
27 } 24 }
28 Thread* thread = Thread::Current(); 25 Thread* thread = Thread::Current();
29 if (thread == NULL) { 26 if (thread == NULL) {
30 return; 27 return;
31 } 28 }
29 ThreadInterruptCallback callback = NULL;
30 void* callback_data = NULL;
31 if (!thread->IsThreadInterrupterEnabled(&callback, &callback_data)) {
32 return;
33 }
32 // Extract thread state. 34 // Extract thread state.
33 ucontext_t* context = reinterpret_cast<ucontext_t*>(context_); 35 ucontext_t* context = reinterpret_cast<ucontext_t*>(context_);
34 mcontext_t mcontext = context->uc_mcontext; 36 mcontext_t mcontext = context->uc_mcontext;
35 InterruptedThreadState its; 37 InterruptedThreadState its;
38 its.tid = thread->id();
36 its.pc = SignalHandler::GetProgramCounter(mcontext); 39 its.pc = SignalHandler::GetProgramCounter(mcontext);
37 its.fp = SignalHandler::GetFramePointer(mcontext); 40 its.fp = SignalHandler::GetFramePointer(mcontext);
38 its.csp = SignalHandler::GetCStackPointer(mcontext); 41 its.csp = SignalHandler::GetCStackPointer(mcontext);
39 its.dsp = SignalHandler::GetDartStackPointer(mcontext); 42 its.dsp = SignalHandler::GetDartStackPointer(mcontext);
40 its.lr = SignalHandler::GetLinkRegister(mcontext); 43 its.lr = SignalHandler::GetLinkRegister(mcontext);
41 Profiler::SampleThread(thread, its); 44 callback(its, callback_data);
42 } 45 }
43 }; 46 };
44 47
45 48
46 void ThreadInterrupter::InterruptThread(Thread* thread) { 49 void ThreadInterrupter::InterruptThread(Thread* thread) {
47 if (FLAG_trace_thread_interrupter) { 50 if (FLAG_trace_thread_interrupter) {
48 OS::Print("ThreadInterrupter interrupting %p\n", thread->id()); 51 OS::Print("ThreadInterrupter interrupting %p\n", thread->id());
49 } 52 }
50 int result = pthread_kill(thread->id(), SIGPROF); 53 int result = pthread_kill(thread->id(), SIGPROF);
51 ASSERT((result == 0) || (result == ESRCH)); 54 ASSERT(result == 0);
52 } 55 }
53 56
54 57
55 void ThreadInterrupter::InstallSignalHandler() { 58 void ThreadInterrupter::InstallSignalHandler() {
56 SignalHandler::Install(ThreadInterrupterMacOS::ThreadInterruptSignalHandler); 59 SignalHandler::Install(ThreadInterrupterMacOS::ThreadInterruptSignalHandler);
57 } 60 }
58 61
59 62
60 void ThreadInterrupter::RemoveSignalHandler() { 63 void ThreadInterrupter::RemoveSignalHandler() {
61 SignalHandler::Remove(); 64 SignalHandler::Remove();
62 } 65 }
63 66
64 } // namespace dart 67 } // namespace dart
65 68
66 #endif // defined(TARGET_OS_MACOS) 69 #endif // defined(TARGET_OS_MACOS)
67 70
OLDNEW
« no previous file with comments | « runtime/vm/thread_interrupter_linux.cc ('k') | runtime/vm/thread_interrupter_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698