Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1425093004: Revert of This CL replaces user_manager::UserID with AccountId. (Closed)

Created:
5 years, 1 month ago by rjkroege
Modified:
5 years, 1 month ago
CC:
aboxhall+watch_chromium.org, achuith+watch_chromium.org, asanka, asvitkine+watch_chromium.org, blundell+watchlist_chromium.org, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, davemoore+watch_chromium.org, dbeam+watch-options_chromium.org, derat+watch_chromium.org, dkrahn+watch_chromium.org, dmazzoni+watch_chromium.org, droger+watchlist_chromium.org, dtseng+watch_chromium.org, dzhioev+watch_chromium.org, extensions-reviews_chromium.org, je_julie, kalyank, kinuko+fileapi, markusheintz_, maxbogue+watch_chromium.org, michaelpg+watch-options_chromium.org, mlamouri+watch-notifications_chromium.org, nektar+watch_chromium.org, nhiroki, nona+watch_chromium.org, oshima+watch_chromium.org, pam+watch_chromium.org, peter+watch_chromium.org, plaree+watch_chromium.org, plundblad+watch_chromium.org, pvalenzuela+watch_chromium.org, rginda+watch_chromium.org, sadrul, sdefresne+watchlist_chromium.org, shuchen+watch_chromium.org, stevenjb+watch_chromium.org, tim+watch_chromium.org, tzik, yusukes+watch_chromium.org, yuzo+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@468875--Chrome-OS-handles-deletion-of-Gmail-account-poorly--Create-AccountID-structure-part2--user_names
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of This CL replaces user_manager::UserID with AccountId. (patchset #12 id:210001 of https://codereview.chromium.org/1412813003/ ) Reason for revert: breaks the GN build on windows: FAILED: E:/b/depot_tools/python276_bin/python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /OUT:ash_unittests.exe /PDB:ash_unittests.exe.pdb @ash_unittests.exe.rsp test_session_state_delegate.obj : error LNK2019: unresolved external symbol "public: __thiscall AccountId::AccountId(class AccountId const &)" (??0AccountId@@QAE@ABV0@@Z) referenced in function "public: virtual class AccountId __thiscall ash::test::MockUserInfo::GetAccountId(void)const " (?GetAccountId@MockUserInfo@test@ash@@UBE?AVAccountId@@XZ) test_session_state_delegate.obj : error LNK2019: unresolved external symbol "public: bool __thiscall AccountId::operator==(class AccountId const &)const " (??8AccountId@@QBE_NABV0@@Z) referenced in function "public: virtual void __thiscall ash::test::TestSessionStateDelegate::SwitchActiveUser(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (?SwitchActiveUser@TestSessionStateDelegate@test@ash@@UAEXABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z) test_session_state_delegate.obj : error LNK2019: unresolved external symbol "public: class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const & __thiscall AccountId::GetUserEmail(void)const " (?GetUserEmail@AccountId@@QBEABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@XZ) referenced in function "public: virtual void __thiscall ash::test::TestSessionStateDelegate::SwitchActiveUser(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (?SwitchActiveUser@TestSessionStateDelegate@test@ash@@UAEXABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z) test_session_state_delegate.obj : error LNK2019: unresolved external symbol "public: static class AccountId __cdecl AccountId::FromUserEmail(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (?FromUserEmail@AccountId@@SA?AV1@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z) referenced in function "class AccountId __cdecl ash::test::`anonymous namespace'::GetAccountIdFromEmail(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (?GetAccountIdFromEmail@?A0x8b8d8028@test@ash@@YA?AVAccountId@@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z) ash_unittests.exe : fatal error LNK1120: 4 unresolved externals ninja: build stopped: subcommand failed. Original issue's description: > This CL replaces user_manager::UserID with AccountId. > > This CL replaces API of user_manager::UserManager, thus modifying API of all > child objects, and all calls to UserManager. > > This is part of transition to AccountId. > > BUG=468875 > TEST=manual > > Committed: https://crrev.com/cd06408625de9e0d5cf4c7c1ede412cb5c82542b > Cr-Commit-Position: refs/heads/master@{#357119} TBR=jochen@chromium.org,achuith@chromium.org,bshe@chromium.org,rogerta@chromium.org,sky@chromium.org,stevenjb@chromium.org,alemate@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=468875 Committed: https://crrev.com/6fa8e13e56429c6cefbba3d5a76f2c41ce28581b Cr-Commit-Position: refs/heads/master@{#357219}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2258 lines, -2662 lines) Patch
M ash/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ash/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ash/ash.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/system/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/user/tray_user.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M ash/system/user/tray_user_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ash/system/user/user_view.cc View 2 chunks +1 line, -3 lines 0 comments Download
M ash/test/test_session_state_delegate.cc View 4 chunks +13 lines, -16 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc View 9 chunks +16 lines, -21 lines 0 comments Download
M chrome/browser/chromeos/accessibility/magnification_manager_browsertest.cc View 15 chunks +27 lines, -30 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_manager.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_profile_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_flow_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/users_private/users_private_api.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api_unittest.cc View 13 chunks +26 lines, -43 lines 0 comments Download
M chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/mount_path_util_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/service_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_persistence_unittest.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/app_launch_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/app_launch_signin_screen.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/auth/chrome_cryptohome_authenticator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/auth/chrome_login_performer.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc View 9 chunks +24 lines, -23 lines 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/bootstrap_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/bootstrap_user_context_initializer.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/bootstrap_user_flow.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_get_keys_operation.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_remove_keys_operation.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager_factory.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 20 chunks +31 lines, -37 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_auto_login_unittest.cc View 10 chunks +25 lines, -24 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 26 chunks +57 lines, -60 lines 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 5 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/login_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_manager_test.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/reauth_stats.h View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/reauth_stats.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/saml/saml_browsertest.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/saml/saml_offline_signin_limiter.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/saml/saml_offline_signin_limiter_unittest.cc View 26 chunks +49 lines, -95 lines 0 comments Download
M chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_image_screen.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_selection_screen.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_selection_screen.cc View 7 chunks +14 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.h View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 19 chunks +36 lines, -36 lines 0 comments Download
M chrome/browser/chromeos/login/signin/auth_sync_observer.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/signin/device_id_browsertest.cc View 7 chunks +31 lines, -40 lines 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_browsertest.cc View 7 chunks +12 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_login_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_login_manager.cc View 4 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/signin/token_handle_fetcher.h View 4 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/login/signin/token_handle_fetcher.cc View 6 chunks +22 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/login/signin/token_handle_util.h View 5 chunks +19 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/login/signin/token_handle_util.cc View 7 chunks +28 lines, -25 lines 0 comments Download
M chrome/browser/chromeos/login/signin_screen_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc View 4 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_creation_controller_new.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/user_flow.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc View 39 chunks +142 lines, -163 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_sync_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/chrome_user_manager_impl.h View 7 chunks +23 lines, -24 lines 0 comments Download
M chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc View 34 chunks +139 lines, -149 lines 0 comments Download
M chrome/browser/chromeos/login/users/fake_chrome_user_manager.h View 2 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc View 5 chunks +41 lines, -42 lines 0 comments Download
M chrome/browser/chromeos/login/users/mock_user_manager.h View 6 chunks +40 lines, -43 lines 0 comments Download
M chrome/browser/chromeos/login/users/mock_user_manager.cc View 4 chunks +18 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/login/users/multi_profile_user_controller_unittest.cc View 13 chunks +25 lines, -48 lines 0 comments Download
M chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc View 4 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/users/user_manager_interface.h View 3 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/users/user_manager_unittest.cc View 4 chunks +29 lines, -47 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc View 5 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc View 19 chunks +28 lines, -30 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_unittest.cc View 2 chunks +17 lines, -29 lines 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/ownership/owner_settings_service_chromeos_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/affiliated_invalidation_service_provider_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/blocking_login_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/policy/consumer_enrollment_handler_factory_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/consumer_enrollment_handler_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/consumer_management_notifier_factory_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/consumer_unenrollment_handler_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 40 chunks +69 lines, -71 lines 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector_browsertest.cc View 4 chunks +14 lines, -25 lines 0 comments Download
M chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/power/extension_event_observer_unittest.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/power/power_prefs_unittest.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/preferences_chromeos_browsertest.cc View 8 chunks +12 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/preferences_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/printer_detector/printer_detector_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/profiles/profile_helper.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/profiles/profile_list_chromeos_unittest.cc View 4 chunks +6 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_service_unittest.cc View 7 chunks +7 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_test_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/device_settings_test_helper.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/status/data_promo_notification_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/system/device_disabling_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/tray_accessibility_browsertest.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/download/notification/download_notification_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest_chromeos.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/braille_display_private/braille_display_private_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api_unittest.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_apitest_chromeos.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/settings_private/prefs_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/crx_installer_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_assets_manager_chromeos.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/chromeos_metrics_provider_unittest.cc View 3 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/net/nss_context_chromeos_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/notifications/message_center_settings_controller_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/signin/chrome_signin_client.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_signin_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/easy_unlock_service_unittest_chromeos.cc View 4 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/supervised_user/chromeos/manager_password_service.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_ui_util.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 3 chunks +15 lines, -18 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_notification_blocker_chromeos_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc View 12 chunks +26 lines, -51 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_chromeos.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_chromeos_unittest.cc View 9 chunks +23 lines, -26 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc View 2 chunks +10 lines, -15 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 7 chunks +25 lines, -32 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 6 chunks +6 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/ui_account_tweaks.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc View 5 chunks +20 lines, -27 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/user_image_source.h View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/user_image_source.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M chromeos/login/auth/cryptohome_authenticator.cc View 7 chunks +38 lines, -25 lines 0 comments Download
M chromeos/login/auth/extended_authenticator_impl.cc View 7 chunks +6 lines, -12 lines 0 comments Download
M chromeos/login/auth/fake_extended_authenticator.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chromeos/login/auth/login_performer.cc View 7 chunks +11 lines, -15 lines 0 comments Download
M chromeos/login/auth/stub_authenticator.cc View 4 chunks +11 lines, -13 lines 0 comments Download
M chromeos/login/auth/user_context.h View 3 chunks +7 lines, -11 lines 0 comments Download
M chromeos/login/auth/user_context.cc View 4 chunks +23 lines, -15 lines 0 comments Download
M components/user_manager.gypi View 2 chunks +1 line, -1 line 0 comments Download
M components/user_manager/BUILD.gn View 3 chunks +1 line, -2 lines 0 comments Download
M components/user_manager/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/user_manager/empty_user_info.h View 1 chunk +1 line, -1 line 0 comments Download
M components/user_manager/empty_user_info.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/user_manager/fake_user_manager.h View 5 chunks +31 lines, -33 lines 0 comments Download
M components/user_manager/fake_user_manager.cc View 8 chunks +41 lines, -49 lines 0 comments Download
M components/user_manager/user.h View 6 chunks +22 lines, -23 lines 0 comments Download
M components/user_manager/user.cc View 14 chunks +45 lines, -38 lines 0 comments Download
A components/user_manager/user_id.h View 1 chunk +17 lines, -0 lines 0 comments Download
M components/user_manager/user_info.h View 2 chunks +4 lines, -4 lines 0 comments Download
M components/user_manager/user_info_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/user_manager/user_info_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/user_manager/user_manager.h View 7 chunks +72 lines, -82 lines 0 comments Download
M components/user_manager/user_manager_base.h View 13 chunks +98 lines, -100 lines 0 comments Download
M components/user_manager/user_manager_base.cc View 32 chunks +281 lines, -297 lines 0 comments Download
M components/wallpaper/wallpaper_manager_base.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rjkroege
Created Revert of This CL replaces user_manager::UserID with AccountId.
5 years, 1 month ago (2015-10-30 23:20:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425093004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425093004/1
5 years, 1 month ago (2015-10-30 23:21:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 23:26:08 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6fa8e13e56429c6cefbba3d5a76f2c41ce28581b Cr-Commit-Position: refs/heads/master@{#357219}
5 years, 1 month ago (2015-10-30 23:27:27 UTC) #4
achuithb
On 2015/10/30 23:20:48, rjkroege wrote: > Created Revert of This CL replaces user_manager::UserID with AccountId. ...
5 years, 1 month ago (2015-11-02 19:44:21 UTC) #5
rjkroege
5 years, 1 month ago (2015-11-02 20:15:55 UTC) #6
Message was sent while issue was closed.
On 2015/11/02 19:44:21, achuithb wrote:
> On 2015/10/30 23:20:48, rjkroege wrote:
> > Created Revert of This CL replaces user_manager::UserID with AccountId.
> 
> This CL passed the CQ. Is there a trybot on the CQ for this?

My understanding is that there isn't. I would hope that this is a temporary
issue related to the roll-out of GN. Sorry for the inconvenience.

Powered by Google App Engine
This is Rietveld 408576698