Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

Issue 1425093004: Revert of This CL replaces user_manager::UserID with AccountId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@468875--Chrome-OS-handles-deletion-of-Gmail-account-poorly--Create-AccountID-structure-part2--user_names
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h" 5 #include "chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <vector> 8 #include <vector>
9 9
10 #include "ash/shell.h" 10 #include "ash/shell.h"
(...skipping 974 matching lines...) Expand 10 before | Expand all | Expand 10 after
985 985
986 void SigninScreenHandler::UpdateAddButtonStatus() { 986 void SigninScreenHandler::UpdateAddButtonStatus() {
987 CallJS("cr.ui.login.DisplayManager.updateAddUserButtonStatus", 987 CallJS("cr.ui.login.DisplayManager.updateAddUserButtonStatus",
988 AllWhitelistedUsersPresent()); 988 AllWhitelistedUsersPresent());
989 } 989 }
990 990
991 void SigninScreenHandler::HandleAuthenticateUser(const std::string& username, 991 void SigninScreenHandler::HandleAuthenticateUser(const std::string& username,
992 const std::string& password) { 992 const std::string& password) {
993 if (!delegate_) 993 if (!delegate_)
994 return; 994 return;
995 UserContext user_context( 995 UserContext user_context(gaia::SanitizeEmail(username));
996 AccountId::FromUserEmail(gaia::SanitizeEmail(username)));
997 user_context.SetKey(Key(password)); 996 user_context.SetKey(Key(password));
998 delegate_->Login(user_context, SigninSpecifics()); 997 delegate_->Login(user_context, SigninSpecifics());
999 } 998 }
1000 999
1001 void SigninScreenHandler::HandleLaunchIncognito() { 1000 void SigninScreenHandler::HandleLaunchIncognito() {
1002 UserContext context(user_manager::USER_TYPE_GUEST, std::string()); 1001 UserContext context(user_manager::USER_TYPE_GUEST, std::string());
1003 if (delegate_) 1002 if (delegate_)
1004 delegate_->Login(context, SigninSpecifics()); 1003 delegate_->Login(context, SigninSpecifics());
1005 } 1004 }
1006 1005
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
1066 TRACE_EVENT_ASYNC_STEP_INTO0("ui", 1065 TRACE_EVENT_ASYNC_STEP_INTO0("ui",
1067 "ShowLoginWebUI", 1066 "ShowLoginWebUI",
1068 LoginDisplayHostImpl::kShowLoginWebUIid, 1067 LoginDisplayHostImpl::kShowLoginWebUIid,
1069 "ShowAddUser"); 1068 "ShowAddUser");
1070 std::string email; 1069 std::string email;
1071 // |args| can be null if it's OOBE. 1070 // |args| can be null if it's OOBE.
1072 if (args) 1071 if (args)
1073 args->GetString(0, &email); 1072 args->GetString(0, &email);
1074 gaia_screen_handler_->set_populated_email(email); 1073 gaia_screen_handler_->set_populated_email(email);
1075 if (!email.empty()) 1074 if (!email.empty())
1076 SendReauthReason(AccountId::FromUserEmail(email)); 1075 SendReauthReason(email);
1077 OnShowAddUser(); 1076 OnShowAddUser();
1078 } 1077 }
1079 1078
1080 void SigninScreenHandler::HandleToggleEnrollmentScreen() { 1079 void SigninScreenHandler::HandleToggleEnrollmentScreen() {
1081 if (delegate_) 1080 if (delegate_)
1082 delegate_->ShowEnterpriseEnrollmentScreen(); 1081 delegate_->ShowEnterpriseEnrollmentScreen();
1083 } 1082 }
1084 1083
1085 void SigninScreenHandler::HandleToggleEnableDebuggingScreen() { 1084 void SigninScreenHandler::HandleToggleEnableDebuggingScreen() {
1086 if (delegate_) 1085 if (delegate_)
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
1169 "ui", "ShowLoginWebUI", LoginDisplayHostImpl::kShowLoginWebUIid); 1168 "ui", "ShowLoginWebUI", LoginDisplayHostImpl::kShowLoginWebUIid);
1170 } 1169 }
1171 webui_visible_ = true; 1170 webui_visible_ = true;
1172 if (preferences_changed_delayed_) 1171 if (preferences_changed_delayed_)
1173 OnPreferencesChanged(); 1172 OnPreferencesChanged();
1174 } 1173 }
1175 1174
1176 void SigninScreenHandler::HandleCancelPasswordChangedFlow( 1175 void SigninScreenHandler::HandleCancelPasswordChangedFlow(
1177 const std::string& user_id) { 1176 const std::string& user_id) {
1178 if (!user_id.empty()) 1177 if (!user_id.empty())
1179 RecordReauthReason(AccountId::FromUserEmail(user_id), 1178 RecordReauthReason(user_id, ReauthReason::PASSWORD_UPDATE_SKIPPED);
1180 ReauthReason::PASSWORD_UPDATE_SKIPPED);
1181 gaia_screen_handler_->StartClearingCookies( 1179 gaia_screen_handler_->StartClearingCookies(
1182 base::Bind(&SigninScreenHandler::CancelPasswordChangedFlowInternal, 1180 base::Bind(&SigninScreenHandler::CancelPasswordChangedFlowInternal,
1183 weak_factory_.GetWeakPtr())); 1181 weak_factory_.GetWeakPtr()));
1184 } 1182 }
1185 1183
1186 void SigninScreenHandler::HandleCancelUserAdding() { 1184 void SigninScreenHandler::HandleCancelUserAdding() {
1187 if (delegate_) 1185 if (delegate_)
1188 delegate_->CancelUserAdding(); 1186 delegate_->CancelUserAdding();
1189 } 1187 }
1190 1188
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
1243 SetUserInputMethod(user_id, ime_state_.get()); 1241 SetUserInputMethod(user_id, ime_state_.get());
1244 WallpaperManager::Get()->SetUserWallpaperDelayed(user_id); 1242 WallpaperManager::Get()->SetUserWallpaperDelayed(user_id);
1245 proximity_auth::ScreenlockBridge::Get()->SetFocusedUser(user_id); 1243 proximity_auth::ScreenlockBridge::Get()->SetFocusedUser(user_id);
1246 if (delegate_) 1244 if (delegate_)
1247 delegate_->CheckUserStatus(user_id); 1245 delegate_->CheckUserStatus(user_id);
1248 if (!test_focus_pod_callback_.is_null()) 1246 if (!test_focus_pod_callback_.is_null())
1249 test_focus_pod_callback_.Run(); 1247 test_focus_pod_callback_.Run();
1250 1248
1251 bool use_24hour_clock = false; 1249 bool use_24hour_clock = false;
1252 if (user_manager::UserManager::Get()->GetKnownUserBooleanPref( 1250 if (user_manager::UserManager::Get()->GetKnownUserBooleanPref(
1253 AccountId::FromUserEmail(user_id), prefs::kUse24HourClock, 1251 user_id, prefs::kUse24HourClock, &use_24hour_clock)) {
1254 &use_24hour_clock)) {
1255 g_browser_process->platform_part() 1252 g_browser_process->platform_part()
1256 ->GetSystemClock() 1253 ->GetSystemClock()
1257 ->SetLastFocusedPodHourClockType(use_24hour_clock ? base::k24HourClock 1254 ->SetLastFocusedPodHourClockType(use_24hour_clock ? base::k24HourClock
1258 : base::k12HourClock); 1255 : base::k12HourClock);
1259 } 1256 }
1260 } 1257 }
1261 1258
1262 void SigninScreenHandler::HandleGetPublicSessionKeyboardLayouts( 1259 void SigninScreenHandler::HandleGetPublicSessionKeyboardLayouts(
1263 const std::string& user_id, 1260 const std::string& user_id,
1264 const std::string& locale) { 1261 const std::string& locale) {
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
1316 const std::string& email) { 1313 const std::string& email) {
1317 // TODO(ginkage): Fix this case once crbug.com/469987 is ready. 1314 // TODO(ginkage): Fix this case once crbug.com/469987 is ready.
1318 /* 1315 /*
1319 if (user_manager::UserManager::Get()->FindUsingSAML(email)) 1316 if (user_manager::UserManager::Get()->FindUsingSAML(email))
1320 RecordReauthReason(email, ReauthReason::INCORRECT_SAML_PASSWORD_ENTERED); 1317 RecordReauthReason(email, ReauthReason::INCORRECT_SAML_PASSWORD_ENTERED);
1321 */ 1318 */
1322 } 1319 }
1323 1320
1324 void SigninScreenHandler::HandleMaxIncorrectPasswordAttempts( 1321 void SigninScreenHandler::HandleMaxIncorrectPasswordAttempts(
1325 const std::string& email) { 1322 const std::string& email) {
1326 RecordReauthReason(AccountId::FromUserEmail(email), 1323 RecordReauthReason(email, ReauthReason::INCORRECT_PASSWORD_ENTERED);
1327 ReauthReason::INCORRECT_PASSWORD_ENTERED);
1328 } 1324 }
1329 1325
1330 bool SigninScreenHandler::AllWhitelistedUsersPresent() { 1326 bool SigninScreenHandler::AllWhitelistedUsersPresent() {
1331 CrosSettings* cros_settings = CrosSettings::Get(); 1327 CrosSettings* cros_settings = CrosSettings::Get();
1332 bool allow_new_user = false; 1328 bool allow_new_user = false;
1333 cros_settings->GetBoolean(kAccountsPrefAllowNewUser, &allow_new_user); 1329 cros_settings->GetBoolean(kAccountsPrefAllowNewUser, &allow_new_user);
1334 if (allow_new_user) 1330 if (allow_new_user)
1335 return false; 1331 return false;
1336 user_manager::UserManager* user_manager = user_manager::UserManager::Get(); 1332 user_manager::UserManager* user_manager = user_manager::UserManager::Get();
1337 const user_manager::UserList& users = user_manager->GetUsers(); 1333 const user_manager::UserList& users = user_manager->GetUsers();
1338 if (!delegate_ || users.size() > kMaxUsers) { 1334 if (!delegate_ || users.size() > kMaxUsers) {
1339 return false; 1335 return false;
1340 } 1336 }
1341 const base::ListValue* whitelist = nullptr; 1337 const base::ListValue* whitelist = nullptr;
1342 if (!cros_settings->GetList(kAccountsPrefUsers, &whitelist) || !whitelist) 1338 if (!cros_settings->GetList(kAccountsPrefUsers, &whitelist) || !whitelist)
1343 return false; 1339 return false;
1344 for (size_t i = 0; i < whitelist->GetSize(); ++i) { 1340 for (size_t i = 0; i < whitelist->GetSize(); ++i) {
1345 std::string whitelisted_user; 1341 std::string whitelisted_user;
1346 // NB: Wildcards in the whitelist are also detected as not present here. 1342 // NB: Wildcards in the whitelist are also detected as not present here.
1347 if (!whitelist->GetString(i, &whitelisted_user) || 1343 if (!whitelist->GetString(i, &whitelisted_user) ||
1348 !user_manager->IsKnownUser( 1344 !user_manager->IsKnownUser(whitelisted_user)) {
1349 AccountId::FromUserEmail(whitelisted_user))) {
1350 return false; 1345 return false;
1351 } 1346 }
1352 } 1347 }
1353 return true; 1348 return true;
1354 } 1349 }
1355 1350
1356 void SigninScreenHandler::CancelPasswordChangedFlowInternal() { 1351 void SigninScreenHandler::CancelPasswordChangedFlowInternal() {
1357 if (delegate_) { 1352 if (delegate_) {
1358 ShowImpl(); 1353 ShowImpl();
1359 delegate_->CancelPasswordChangedFlow(); 1354 delegate_->CancelPasswordChangedFlow();
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
1416 return gaia_screen_handler_->frame_error(); 1411 return gaia_screen_handler_->frame_error();
1417 } 1412 }
1418 1413
1419 void SigninScreenHandler::OnCapsLockChanged(bool enabled) { 1414 void SigninScreenHandler::OnCapsLockChanged(bool enabled) {
1420 caps_lock_enabled_ = enabled; 1415 caps_lock_enabled_ = enabled;
1421 if (page_is_ready()) 1416 if (page_is_ready())
1422 CallJS("login.AccountPickerScreen.setCapsLockState", caps_lock_enabled_); 1417 CallJS("login.AccountPickerScreen.setCapsLockState", caps_lock_enabled_);
1423 } 1418 }
1424 1419
1425 } // namespace chromeos 1420 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698