Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: chrome/browser/chromeos/settings/device_settings_service_unittest.cc

Issue 1425093004: Revert of This CL replaces user_manager::UserID with AccountId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@468875--Chrome-OS-handles-deletion-of-Gmail-account-poorly--Create-AccountID-structure-part2--user_names
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/settings/device_settings_service.h" 5 #include "chrome/browser/chromeos/settings/device_settings_service.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/bind_helpers.h" 9 #include "base/bind_helpers.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 } 163 }
164 164
165 TEST_F(DeviceSettingsServiceTest, StoreSuccess) { 165 TEST_F(DeviceSettingsServiceTest, StoreSuccess) {
166 owner_key_util_->Clear(); 166 owner_key_util_->Clear();
167 device_settings_test_helper_.set_policy_blob(std::string()); 167 device_settings_test_helper_.set_policy_blob(std::string());
168 ReloadDeviceSettings(); 168 ReloadDeviceSettings();
169 EXPECT_EQ(DeviceSettingsService::STORE_KEY_UNAVAILABLE, 169 EXPECT_EQ(DeviceSettingsService::STORE_KEY_UNAVAILABLE,
170 device_settings_service_.status()); 170 device_settings_service_.status());
171 171
172 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey()); 172 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey());
173 InitOwner(AccountId::FromUserEmail(device_policy_.policy_data().username()), 173 InitOwner(device_policy_.policy_data().username(), true);
174 true);
175 device_settings_service_.Store( 174 device_settings_service_.Store(
176 device_policy_.GetCopy(), 175 device_policy_.GetCopy(),
177 base::Bind(&DeviceSettingsServiceTest::SetOperationCompleted, 176 base::Bind(&DeviceSettingsServiceTest::SetOperationCompleted,
178 base::Unretained(this))); 177 base::Unretained(this)));
179 FlushDeviceSettings(); 178 FlushDeviceSettings();
180 EXPECT_TRUE(operation_completed_); 179 EXPECT_TRUE(operation_completed_);
181 EXPECT_EQ(DeviceSettingsService::STORE_SUCCESS, 180 EXPECT_EQ(DeviceSettingsService::STORE_SUCCESS,
182 device_settings_service_.status()); 181 device_settings_service_.status());
183 CheckPolicy(); 182 CheckPolicy();
184 } 183 }
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
237 ASSERT_TRUE(device_settings_service_.GetPublicKey().get()); 236 ASSERT_TRUE(device_settings_service_.GetPublicKey().get());
238 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded()); 237 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded());
239 std::vector<uint8> key; 238 std::vector<uint8> key;
240 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key)); 239 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key));
241 EXPECT_EQ(device_settings_service_.GetPublicKey()->data(), key); 240 EXPECT_EQ(device_settings_service_.GetPublicKey()->data(), key);
242 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN, 241 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN,
243 device_settings_service_.GetOwnershipStatus()); 242 device_settings_service_.GetOwnershipStatus());
244 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN, ownership_status_); 243 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN, ownership_status_);
245 244
246 owner_key_util_->SetPrivateKey(device_policy_.GetSigningKey()); 245 owner_key_util_->SetPrivateKey(device_policy_.GetSigningKey());
247 InitOwner(AccountId::FromUserEmail(device_policy_.policy_data().username()), 246 InitOwner(device_policy_.policy_data().username(), true);
248 true);
249 device_settings_service_.GetOwnershipStatusAsync( 247 device_settings_service_.GetOwnershipStatusAsync(
250 base::Bind(&DeviceSettingsServiceTest::SetOwnershipStatus, 248 base::Bind(&DeviceSettingsServiceTest::SetOwnershipStatus,
251 base::Unretained(this))); 249 base::Unretained(this)));
252 FlushDeviceSettings(); 250 FlushDeviceSettings();
253 EXPECT_TRUE(device_settings_service_.HasPrivateOwnerKey()); 251 EXPECT_TRUE(device_settings_service_.HasPrivateOwnerKey());
254 ASSERT_TRUE(device_settings_service_.GetPublicKey().get()); 252 ASSERT_TRUE(device_settings_service_.GetPublicKey().get());
255 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded()); 253 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded());
256 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key)); 254 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key));
257 EXPECT_EQ(device_settings_service_.GetPublicKey()->data(), key); 255 EXPECT_EQ(device_settings_service_.GetPublicKey()->data(), key);
258 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN, 256 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN,
259 device_settings_service_.GetOwnershipStatus()); 257 device_settings_service_.GetOwnershipStatus());
260 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN, ownership_status_); 258 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN, ownership_status_);
261 } 259 }
262 260
263 TEST_F(DeviceSettingsServiceTest, OnTPMTokenReadyForNonOwner) { 261 TEST_F(DeviceSettingsServiceTest, OnTPMTokenReadyForNonOwner) {
264 owner_key_util_->Clear(); 262 owner_key_util_->Clear();
265 263
266 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey()); 264 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
267 EXPECT_FALSE(device_settings_service_.GetPublicKey().get()); 265 EXPECT_FALSE(device_settings_service_.GetPublicKey().get());
268 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN, 266 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN,
269 device_settings_service_.GetOwnershipStatus()); 267 device_settings_service_.GetOwnershipStatus());
270 268
271 const std::string& user_id = device_policy_.policy_data().username(); 269 const std::string& user_id = device_policy_.policy_data().username();
272 InitOwner(AccountId::FromUserEmail(user_id), false); 270 InitOwner(user_id, false);
273 OwnerSettingsServiceChromeOS* service = 271 OwnerSettingsServiceChromeOS* service =
274 OwnerSettingsServiceChromeOSFactory::GetForBrowserContext(profile_.get()); 272 OwnerSettingsServiceChromeOSFactory::GetForBrowserContext(profile_.get());
275 ASSERT_TRUE(service); 273 ASSERT_TRUE(service);
276 service->IsOwnerAsync(base::Bind(&DeviceSettingsServiceTest::OnIsOwner, 274 service->IsOwnerAsync(base::Bind(&DeviceSettingsServiceTest::OnIsOwner,
277 base::Unretained(this))); 275 base::Unretained(this)));
278 276
279 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey()); 277 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey());
280 ReloadDeviceSettings(); 278 ReloadDeviceSettings();
281 279
282 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey()); 280 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
(...skipping 24 matching lines...) Expand all
307 TEST_F(DeviceSettingsServiceTest, OwnerPrivateKeyInTPMToken) { 305 TEST_F(DeviceSettingsServiceTest, OwnerPrivateKeyInTPMToken) {
308 owner_key_util_->Clear(); 306 owner_key_util_->Clear();
309 307
310 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey()); 308 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
311 EXPECT_FALSE(device_settings_service_.GetPublicKey().get()); 309 EXPECT_FALSE(device_settings_service_.GetPublicKey().get());
312 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN, 310 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN,
313 device_settings_service_.GetOwnershipStatus()); 311 device_settings_service_.GetOwnershipStatus());
314 312
315 const std::string& user_id = device_policy_.policy_data().username(); 313 const std::string& user_id = device_policy_.policy_data().username();
316 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey()); 314 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey());
317 InitOwner(AccountId::FromUserEmail(user_id), false); 315 InitOwner(user_id, false);
318 OwnerSettingsServiceChromeOS* service = 316 OwnerSettingsServiceChromeOS* service =
319 OwnerSettingsServiceChromeOSFactory::GetForBrowserContext(profile_.get()); 317 OwnerSettingsServiceChromeOSFactory::GetForBrowserContext(profile_.get());
320 ASSERT_TRUE(service); 318 ASSERT_TRUE(service);
321 ReloadDeviceSettings(); 319 ReloadDeviceSettings();
322 320
323 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey()); 321 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
324 ASSERT_TRUE(device_settings_service_.GetPublicKey().get()); 322 ASSERT_TRUE(device_settings_service_.GetPublicKey().get());
325 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded()); 323 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded());
326 std::vector<uint8> key; 324 std::vector<uint8> key;
327 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key)); 325 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key));
(...skipping 15 matching lines...) Expand all
343 TEST_F(DeviceSettingsServiceTest, OnTPMTokenReadyForOwner) { 341 TEST_F(DeviceSettingsServiceTest, OnTPMTokenReadyForOwner) {
344 owner_key_util_->Clear(); 342 owner_key_util_->Clear();
345 343
346 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey()); 344 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
347 EXPECT_FALSE(device_settings_service_.GetPublicKey().get()); 345 EXPECT_FALSE(device_settings_service_.GetPublicKey().get());
348 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN, 346 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN,
349 device_settings_service_.GetOwnershipStatus()); 347 device_settings_service_.GetOwnershipStatus());
350 348
351 const std::string& user_id = device_policy_.policy_data().username(); 349 const std::string& user_id = device_policy_.policy_data().username();
352 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey()); 350 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey());
353 InitOwner(AccountId::FromUserEmail(user_id), false); 351 InitOwner(user_id, false);
354 OwnerSettingsServiceChromeOS* service = 352 OwnerSettingsServiceChromeOS* service =
355 OwnerSettingsServiceChromeOSFactory::GetForBrowserContext(profile_.get()); 353 OwnerSettingsServiceChromeOSFactory::GetForBrowserContext(profile_.get());
356 ASSERT_TRUE(service); 354 ASSERT_TRUE(service);
357 service->IsOwnerAsync(base::Bind(&DeviceSettingsServiceTest::OnIsOwner, 355 service->IsOwnerAsync(base::Bind(&DeviceSettingsServiceTest::OnIsOwner,
358 base::Unretained(this))); 356 base::Unretained(this)));
359 ReloadDeviceSettings(); 357 ReloadDeviceSettings();
360 358
361 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey()); 359 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
362 ASSERT_TRUE(device_settings_service_.GetPublicKey().get()); 360 ASSERT_TRUE(device_settings_service_.GetPublicKey().get());
363 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded()); 361 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded());
(...skipping 23 matching lines...) Expand all
387 owner_key_util_->Clear(); 385 owner_key_util_->Clear();
388 386
389 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey()); 387 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
390 EXPECT_FALSE(device_settings_service_.GetPublicKey().get()); 388 EXPECT_FALSE(device_settings_service_.GetPublicKey().get());
391 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN, 389 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN,
392 device_settings_service_.GetOwnershipStatus()); 390 device_settings_service_.GetOwnershipStatus());
393 391
394 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey()); 392 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey());
395 owner_key_util_->SetPrivateKey(device_policy_.GetSigningKey()); 393 owner_key_util_->SetPrivateKey(device_policy_.GetSigningKey());
396 394
397 InitOwner(AccountId::FromUserEmail(device_policy_.policy_data().username()), 395 InitOwner(device_policy_.policy_data().username(), true);
398 true);
399 ReloadDeviceSettings(); 396 ReloadDeviceSettings();
400 FlushDeviceSettings(); 397 FlushDeviceSettings();
401 398
402 EXPECT_TRUE(device_settings_service_.HasPrivateOwnerKey()); 399 EXPECT_TRUE(device_settings_service_.HasPrivateOwnerKey());
403 ASSERT_TRUE(device_settings_service_.GetPublicKey().get()); 400 ASSERT_TRUE(device_settings_service_.GetPublicKey().get());
404 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded()); 401 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded());
405 std::vector<uint8> key; 402 std::vector<uint8> key;
406 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key)); 403 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key));
407 EXPECT_EQ(device_settings_service_.GetPublicKey()->data(), key); 404 EXPECT_EQ(device_settings_service_.GetPublicKey()->data(), key);
408 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN, 405 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN,
(...skipping 25 matching lines...) Expand all
434 device_settings_service_.AddObserver(&observer_); 431 device_settings_service_.AddObserver(&observer_);
435 432
436 EXPECT_CALL(observer_, OwnershipStatusChanged()).Times(1); 433 EXPECT_CALL(observer_, OwnershipStatusChanged()).Times(1);
437 EXPECT_CALL(observer_, DeviceSettingsUpdated()).Times(1); 434 EXPECT_CALL(observer_, DeviceSettingsUpdated()).Times(1);
438 ReloadDeviceSettings(); 435 ReloadDeviceSettings();
439 Mock::VerifyAndClearExpectations(&observer_); 436 Mock::VerifyAndClearExpectations(&observer_);
440 437
441 EXPECT_CALL(observer_, OwnershipStatusChanged()).Times(1); 438 EXPECT_CALL(observer_, OwnershipStatusChanged()).Times(1);
442 EXPECT_CALL(observer_, DeviceSettingsUpdated()).Times(1); 439 EXPECT_CALL(observer_, DeviceSettingsUpdated()).Times(1);
443 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey()); 440 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey());
444 InitOwner(AccountId::FromUserEmail(device_policy_.policy_data().username()), 441 InitOwner(device_policy_.policy_data().username(), true);
445 true);
446 ReloadDeviceSettings(); 442 ReloadDeviceSettings();
447 Mock::VerifyAndClearExpectations(&observer_); 443 Mock::VerifyAndClearExpectations(&observer_);
448 444
449 EXPECT_CALL(observer_, OwnershipStatusChanged()).Times(0); 445 EXPECT_CALL(observer_, OwnershipStatusChanged()).Times(0);
450 EXPECT_CALL(observer_, DeviceSettingsUpdated()).Times(1); 446 EXPECT_CALL(observer_, DeviceSettingsUpdated()).Times(1);
451 device_settings_service_.Store(device_policy_.GetCopy(), base::Closure()); 447 device_settings_service_.Store(device_policy_.GetCopy(), base::Closure());
452 FlushDeviceSettings(); 448 FlushDeviceSettings();
453 Mock::VerifyAndClearExpectations(&observer_); 449 Mock::VerifyAndClearExpectations(&observer_);
454 450
455 EXPECT_CALL(observer_, OwnershipStatusChanged()).Times(0); 451 EXPECT_CALL(observer_, OwnershipStatusChanged()).Times(0);
456 EXPECT_CALL(observer_, DeviceSettingsUpdated()).Times(1); 452 EXPECT_CALL(observer_, DeviceSettingsUpdated()).Times(1);
457 device_settings_service_.PropertyChangeComplete(true); 453 device_settings_service_.PropertyChangeComplete(true);
458 FlushDeviceSettings(); 454 FlushDeviceSettings();
459 Mock::VerifyAndClearExpectations(&observer_); 455 Mock::VerifyAndClearExpectations(&observer_);
460 456
461 device_settings_service_.RemoveObserver(&observer_); 457 device_settings_service_.RemoveObserver(&observer_);
462 } 458 }
463 459
464 } // namespace chromeos 460 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698