Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1425013006: Using override keyword in ObjectVisitor class hierarchy. (Closed)

Created:
5 years, 1 month ago by Igor Sheludko
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Using override keyword in ObjectVisitor class hierarchy. Committed: https://crrev.com/82a54b38e7112051b773d616637ce750e788e297 Cr-Commit-Position: refs/heads/master@{#31819}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -64 lines) Patch
M src/api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/context-measure.h View 1 chunk +1 line, -1 line 0 comments Download
M src/debug/liveedit.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M src/heap/heap.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/heap/heap.cc View 7 chunks +11 lines, -8 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 12 chunks +17 lines, -17 lines 0 comments Download
M src/heap/scavenger.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 5 chunks +8 lines, -10 lines 0 comments Download
M src/snapshot/serialize.cc View 1 chunk +11 lines, -11 lines 0 comments Download
M test/cctest/test-global-handles.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425013006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425013006/1
5 years, 1 month ago (2015-11-04 17:56:21 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-04 18:22:55 UTC) #5
Igor Sheludko
PTAL Yang: debug and snapshot, Michi: the rest
5 years, 1 month ago (2015-11-04 18:29:09 UTC) #7
Yang
lgtm.
5 years, 1 month ago (2015-11-05 06:46:35 UTC) #8
Michael Starzinger
LGTM.
5 years, 1 month ago (2015-11-05 09:08:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425013006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425013006/1
5 years, 1 month ago (2015-11-05 09:30:36 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 09:32:10 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 09:32:50 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/82a54b38e7112051b773d616637ce750e788e297
Cr-Commit-Position: refs/heads/master@{#31819}

Powered by Google App Engine
This is Rietveld 408576698