test/cctest/test-heap.cc - Issue 1425013006: Using override keyword in ObjectVisitor class hierarchy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-heap.cc

Issue 1425013006: Using override keyword in ObjectVisitor class hierarchy. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-heap.cc

diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc

index fa9051e3aa193db03b2f0e4b0de0caa7fc3f8bd1..1ecd95e1a86d5baa38b1f40e5eea98758735bfd3 100644

--- a/test/cctest/test-heap.cc

+++ b/test/cctest/test-heap.cc

@@ -4475,7 +4475,7 @@ TEST(LargeObjectSlotRecording) {

class DummyVisitor : public ObjectVisitor {

public:

- void VisitPointers(Object** start, Object** end) { }

+ void VisitPointers(Object** start, Object** end) override {}

};

« no previous file with comments | « test/cctest/test-global-handles.cc ('k') | no next file » | no next file with comments »