Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: src/api.cc

Issue 1425013006: Using override keyword in ObjectVisitor class hierarchy. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/context-measure.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index 27411c19a05b3891ef8ed3d85d2f149571152b51..0c019a73848744c779db8cde72722c4289ad8051 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -7618,10 +7618,10 @@ class VisitorAdapter : public i::ObjectVisitor {
public:
explicit VisitorAdapter(PersistentHandleVisitor* visitor)
: visitor_(visitor) {}
- virtual void VisitPointers(i::Object** start, i::Object** end) {
+ void VisitPointers(i::Object** start, i::Object** end) override {
UNREACHABLE();
}
- virtual void VisitEmbedderReference(i::Object** p, uint16_t class_id) {
+ void VisitEmbedderReference(i::Object** p, uint16_t class_id) override {
Value* value = ToApi<Value>(i::Handle<i::Object>(p));
visitor_->VisitPersistentHandle(
reinterpret_cast<Persistent<Value>*>(&value), class_id);
« no previous file with comments | « no previous file | src/context-measure.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698