Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1424943008: [turbofan] Desugar lookup slot optimization in graph builder. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Desugar lookup slot optimization in graph builder. This moves the optimization for variables loads targeting lookup slots in DYNAMIC_GLOBAL and DYNAMIC_LOCAL mode into the AstGraphBuilder. This way we implicitly get all optimizations that target global loads and context loads for free. R=bmeurer@chromium.org BUG=v8:4513 LOG=n Committed: https://crrev.com/3e73ce49545b04125f75f4dd720d5844933920b0 Cr-Commit-Position: refs/heads/master@{#31713}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -413 lines) Patch
M src/compiler/ast-graph-builder.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 5 chunks +116 lines, -38 lines 0 comments Download
M src/compiler/control-builders.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/control-builders.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 2 chunks +2 lines, -13 lines 0 comments Download
M src/compiler/js-operator.h View 2 chunks +11 lines, -72 lines 0 comments Download
M src/compiler/js-operator.cc View 2 chunks +18 lines, -84 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +0 lines, -120 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/operator-properties.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +1 line, -8 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +0 lines, -70 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
5 years, 1 month ago (2015-11-02 13:05:44 UTC) #1
Benedikt Meurer
LGTM with nits. https://codereview.chromium.org/1424943008/diff/1/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (right): https://codereview.chromium.org/1424943008/diff/1/src/compiler/ast-graph-builder.cc#newcode3068 src/compiler/ast-graph-builder.cc:3068: static const int kMaxCheckDepth = 30; ...
5 years, 1 month ago (2015-11-02 13:15:56 UTC) #2
Michael Starzinger
https://codereview.chromium.org/1424943008/diff/1/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (right): https://codereview.chromium.org/1424943008/diff/1/src/compiler/ast-graph-builder.cc#newcode3068 src/compiler/ast-graph-builder.cc:3068: static const int kMaxCheckDepth = 30; On 2015/11/02 13:15:55, ...
5 years, 1 month ago (2015-11-02 13:35:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424943008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424943008/20001
5 years, 1 month ago (2015-11-02 13:53:48 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-02 13:55:28 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 13:55:41 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e73ce49545b04125f75f4dd720d5844933920b0
Cr-Commit-Position: refs/heads/master@{#31713}

Powered by Google App Engine
This is Rietveld 408576698