Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: test/unittests/compiler/js-typed-lowering-unittest.cc

Issue 1424943008: [turbofan] Desugar lookup slot optimization in graph builder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comment. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/verifier.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/compiler/js-typed-lowering-unittest.cc
diff --git a/test/unittests/compiler/js-typed-lowering-unittest.cc b/test/unittests/compiler/js-typed-lowering-unittest.cc
index 50d557d212afc00050c9f68a15442e58b0985be4..cfee0bd4d02d0ca7abc96c628de35a8cc171cf4b 100644
--- a/test/unittests/compiler/js-typed-lowering-unittest.cc
+++ b/test/unittests/compiler/js-typed-lowering-unittest.cc
@@ -929,76 +929,6 @@ TEST_F(JSTypedLoweringTest, JSLoadNamedStringLength) {
// -----------------------------------------------------------------------------
-// JSLoadDynamicGlobal
-
-
-TEST_F(JSTypedLoweringTest, JSLoadDynamicGlobal) {
- Node* const context = Parameter(Type::Any());
- Node* const vector = UndefinedConstant();
- Node* const frame_state = EmptyFrameState();
- Node* const effect = graph()->start();
- Node* const control = graph()->start();
- Handle<String> name = factory()->object_string();
- VectorSlotPair feedback;
- for (int i = 0; i < DynamicGlobalAccess::kMaxCheckDepth; ++i) {
- uint32_t bitset = 1 << i; // Only single check.
- Reduction r = Reduce(graph()->NewNode(
- javascript()->LoadDynamicGlobal(name, bitset, feedback,
- NOT_INSIDE_TYPEOF),
- vector, context, context, frame_state, frame_state, effect, control));
- ASSERT_TRUE(r.Changed());
- EXPECT_THAT(
- r.replacement(),
- IsPhi(kMachAnyTagged, _, _,
- IsMerge(
- IsIfTrue(IsBranch(
- IsReferenceEqual(
- Type::Tagged(),
- IsLoadContext(
- ContextAccess(i, Context::EXTENSION_INDEX, false),
- context),
- IsNumberConstant(BitEq(0.0))),
- control)),
- _)));
- }
-}
-
-
-// -----------------------------------------------------------------------------
-// JSLoadDynamicContext
-
-
-TEST_F(JSTypedLoweringTest, JSLoadDynamicContext) {
- Node* const context = Parameter(Type::Any());
- Node* const frame_state = EmptyFrameState();
- Node* const effect = graph()->start();
- Node* const control = graph()->start();
- Handle<String> name = factory()->object_string();
- for (int i = 0; i < DynamicContextAccess::kMaxCheckDepth; ++i) {
- uint32_t bitset = 1 << i; // Only single check.
- Reduction r = Reduce(
- graph()->NewNode(javascript()->LoadDynamicContext(name, bitset, 23, 42),
- context, context, frame_state, effect, control));
- ASSERT_TRUE(r.Changed());
- EXPECT_THAT(
- r.replacement(),
- IsPhi(kMachAnyTagged,
- IsLoadContext(ContextAccess(23, 42, false), context), _,
- IsMerge(
- IsIfTrue(IsBranch(
- IsReferenceEqual(
- Type::Tagged(),
- IsLoadContext(
- ContextAccess(i, Context::EXTENSION_INDEX, false),
- context),
- IsNumberConstant(BitEq(0.0))),
- control)),
- _)));
- }
-}
-
-
-// -----------------------------------------------------------------------------
// JSAdd
« no previous file with comments | « src/compiler/verifier.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698