src/compiler/verifier.cc - Issue 1424943008: [turbofan] Desugar lookup slot optimization in graph builder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/verifier.cc

Issue 1424943008: [turbofan] Desugar lookup slot optimization in graph builder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comment. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/verifier.cc

diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc

index cab3e9fcbb82c8833cccdff75e836ec6b2def516..340f2bf660cdc428bd50f6bb109475553834f18c 100644

--- a/src/compiler/verifier.cc

+++ b/src/compiler/verifier.cc

@@ -544,8 +544,7 @@ void Verifier::Visitor::Check(Node* node) {

break;

case IrOpcode::kJSLoadContext:

- case IrOpcode::kJSLoadDynamicGlobal:

- case IrOpcode::kJSLoadDynamicContext:

+ case IrOpcode::kJSLoadDynamic:

// Type can be anything.

CheckUpperIs(node, Type::Any());

break;

« no previous file with comments | « src/compiler/typer.cc ('k') | test/unittests/compiler/js-typed-lowering-unittest.cc » ('j') | no next file with comments »