Allow higher unicode characters in XMB files.

Allow higher unicode characters in XMB files.

The XMB tool has a regex of invalid XML characters, which erroneously
contained all unicode characters in the supplementary planes (U+10000 to
U+10FFFF). The tool would silently replace these characters with spaces
when generating XMB files, which caused problems recently when an emoji
character was added to a grd file. The translation console supports
these characters, so GRIT should too.

The XMB tool now supports these characters, and now raises an exception
if an invalid character is used (instead of silently replacing it with a
space).

BUG=554070

[newt (away), 2015-11-10 17:01:20]

Description was changed from

==========
Allow higher unicode characters in XMB files.

The XMB tool has a regex of invalid XML characters, which erroneously
contained all unicode characters in the supplementary planes (U+10000 to
U+10FFFF). The tool would silently replace these characters with spaces
when generating XMB files, which caused problems recently when an emoji
character was added to a grd file. The translation console supports
these characters, so GRIT should too.

The XMB tool now supports these characters, and now raises an exception
if an invalid character is used (instead of silently replacing it with a
space).

BUG=498288
==========

to

==========
Allow higher unicode characters in XMB files.

The XMB tool has a regex of invalid XML characters, which erroneously
contained all unicode characters in the supplementary planes (U+10000 to
U+10FFFF). The tool would silently replace these characters with spaces
when generating XMB files, which caused problems recently when an emoji
character was added to a grd file. The translation console supports
these characters, so GRIT should too.

The XMB tool now supports these characters, and now raises an exception
if an invalid character is used (instead of silently replacing it with a
space).

BUG=554070
==========

[newt (away), 2015-11-10 17:21:14]

newt@chromium.org changed reviewers:
+ thakis@chromium.org

[newt (away), 2015-11-10 17:21:14]

PTAL

[newt (away), 2015-11-10 17:22:52]

https://codereview.chromium.org/1424933018/diff/20001/grit/tool/xmb.py
File grit/tool/xmb.py (right):

https://codereview.chromium.org/1424933018/diff/20001/grit/tool/xmb.py#newcode46
grit/tool/xmb.py:46: if illegal_chars:
All of Chrome's grd files pass this stricter error checking (as you'd hope!).
It's possible that some other project contains illegal characters but I think
they'd rather know about that just continue to get translations with missing
characters.

[newt (away), 2015-11-12 20:22:29]

friendly ping?

[Nico, 2015-11-12 20:25:12]

(grit stuff in my mind is blocked on
https://code.google.com/p/chromium/issues/detail?id=553682 which is taking a bit
longer than i thought. i need to merge 2 changes from svn to the new location,
then you can rebase this on top of src/)

[newt (away), 2015-11-12 22:21:26]

Ah, the move to src is happening right now -- Exciting!

I'll wait until that's settled then update this CL.

[Nico, 2015-11-13 01:29:00]

On 2015/11/12 22:21:26, newt wrote:
> Ah, the move to src is happening right now -- Exciting!
> 
> I'll wait until that's settled then update this CL.

Ok, it's settled now.

[newt (away), 2015-11-13 02:32:58]

Moved review to https://codereview.chromium.org/1443483003