Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1443483003: Allow higher unicode characters in XMB files. (Closed)

Created:
5 years, 1 month ago by newt (away)
Modified:
5 years, 1 month ago
Reviewers:
Nico
CC:
grit-developer_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow higher unicode characters in XMB files. The XMB tool has a regex of invalid XML characters, which erroneously contained all unicode characters in the supplementary planes (U+10000 to U+10FFFF). The tool would silently replace these characters with spaces when generating XMB files, which caused problems recently when an emoji character was added to a grd file. The translation console supports these characters, so GRIT should too. The XMB tool now supports these characters, and now raises an exception if an invalid character is used (instead of silently replacing it with a space). BUG=498288

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : reuploading to fix base URL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M tools/grit/grit/tool/xmb.py View 1 2 2 chunks +8 lines, -2 lines 0 comments Download
M tools/grit/grit/tool/xmb_unittest.py View 1 2 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
newt (away)
PTAL
5 years, 1 month ago (2015-11-13 02:33:12 UTC) #2
Nico
lgtm!
5 years, 1 month ago (2015-11-13 04:31:20 UTC) #3
Nico
wait, this has an svn base url, this looks strange too…
5 years, 1 month ago (2015-11-13 04:32:04 UTC) #4
Nico
if you reupload this from your regular (git) chromium checkout, you'll probably get a cq ...
5 years, 1 month ago (2015-11-13 04:32:37 UTC) #5
newt (away)
5 years, 1 month ago (2015-11-13 17:48:25 UTC) #6
On 2015/11/13 04:32:37, Nico wrote:
> if you reupload this from your regular (git) chromium checkout, you'll
probably
> get a cq checkbox

Weird. I reuploaded, and the Base URL is now for Chromium, but it's an SVN URL
instead of a git URL.

Trying again with a new issue: https://codereview.chromium.org/1440313003/

Powered by Google App Engine
This is Rietveld 408576698