Issue 1424913008: Combine tab background image getter code into one place.

Issue 1424913008: Combine tab background image getter code into one place. (Closed)

Created:
5 years, 1 month ago by Peter Kasting

Modified:
5 years, 1 month ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, miu+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@combine_tab_drawing

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Combine tab background image getter code into one place. In the future, the new tab button painting routine will want to know if there's a custom image, but for now it doesn't use that value. BUG=none TEST=none R=sky@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/1d15ec163d32c65b1d6ed3e8cc9165613e9bacb8

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -35 lines)			Patch
M	chrome/browser/ui/views/tabs/tab.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab.cc	View	2 chunks	+2 lines, -25 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_controller.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_strip.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_strip.cc	View	2 chunks	+24 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_unittest.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download

Depends on Patchset:

Dependent Patchsets:

Total messages: 5 (1 generated)

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/1d15ec163d32c65b1d6ed3e8cc9165613e9bacb8 Cr-Commit-Position: refs/heads/master@{#358017}

5 years, 1 month ago (2015-11-05 09:02:41 UTC) #4

Peter Kasting

5 years, 1 month ago (2015-11-05 09:03:05 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1d15ec163d32c65b1d6ed3e8cc9165613e9bacb8 (presubmit successful).