Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1414203012: Combine active and inactive tab background drawing functions. (Closed)

Created:
5 years, 1 month ago by Peter Kasting
Modified:
5 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@combine_radial_gradients
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Combine active and inactive tab background drawing functions. BUG=none TEST=none R=sky@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/c526f0ede5f26094ee6ff25b258bc7d18ff4b641

Patch Set 1 #

Patch Set 2 : Fix compile #

Patch Set 3 : Compile fix for realz #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -88 lines) Patch
M chrome/browser/ui/views/tabs/tab.h View 1 chunk +10 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 1 2 4 chunks +60 lines, -85 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (1 generated)
Peter Kasting
5 years, 1 month ago (2015-11-05 00:08:13 UTC) #2
sky
LGTM
5 years, 1 month ago (2015-11-05 03:29:27 UTC) #3
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/c526f0ede5f26094ee6ff25b258bc7d18ff4b641 Cr-Commit-Position: refs/heads/master@{#358016}
5 years, 1 month ago (2015-11-05 08:31:21 UTC) #4
Peter Kasting
5 years, 1 month ago (2015-11-05 08:36:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
c526f0ede5f26094ee6ff25b258bc7d18ff4b641 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698