Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1403413006: Distill the concept of the "tab top exclusion region", an area inside the tab (Closed)

Created:
5 years, 1 month ago by Peter Kasting
Modified:
5 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@combine_background_image_getters
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Distill the concept of the "tab top exclusion region", an area inside the tab bounds which we don't actually want to be part of hit testing or count towards the gap above tabs in restored mode. I'd imagine the origin of this is in some kind of change we made to our theme resources in the past where we made the images taller but didn't actually want the tab metrics to change, so we just tweaked numbers in various places. This will have a different size (0) in Material Design, and we'll also use this value in a future change to fix some alignment problems in theme drawing that have been introduced over the years. BUG=none TEST=none Committed: https://crrev.com/1a37cd0f8f97ee46836d422c7a659fdb6468ba62 Cr-Commit-Position: refs/heads/master@{#358088}

Patch Set 1 #

Patch Set 2 : Fix indenting error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -16 lines) Patch
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 2 chunks +13 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/layout_constants.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/layout_constants.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
Peter Kasting
5 years, 1 month ago (2015-11-05 06:58:19 UTC) #2
sky
LGTM
5 years, 1 month ago (2015-11-05 17:02:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403413006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403413006/20001
5 years, 1 month ago (2015-11-05 17:29:17 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-05 18:14:25 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 18:16:03 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1a37cd0f8f97ee46836d422c7a659fdb6468ba62
Cr-Commit-Position: refs/heads/master@{#358088}

Powered by Google App Engine
This is Rietveld 408576698