Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 1424793006: [Media, Android] Always explicitly set the notification play/pause button visibility (Closed)

Created:
5 years, 1 month ago by whywhat
Modified:
5 years, 1 month ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media, Android] Always explicitly set the notification play/pause button visibility Also moved the code forming the content view into createContentView(). BUG=541629 Committed: https://crrev.com/b8815dd550cb323516daf7c24ec531d3b8651c31 Cr-Commit-Position: refs/heads/master@{#356912}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -25 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java View 2 chunks +31 lines, -25 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
whywhat
PTaL
5 years, 1 month ago (2015-10-29 13:05:53 UTC) #2
mlamouri (slow - plz ping)
lgtm
5 years, 1 month ago (2015-10-29 18:40:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424793006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424793006/1
5 years, 1 month ago (2015-10-29 18:41:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-29 19:30:53 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 19:31:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8815dd550cb323516daf7c24ec531d3b8651c31
Cr-Commit-Position: refs/heads/master@{#356912}

Powered by Google App Engine
This is Rietveld 408576698