Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1410733008: [Cast, Android, Presentation API] Check if mApiClient is connected or connecting before using it an… (Closed)

Created:
5 years, 1 month ago by whywhat
Modified:
5 years, 1 month ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, media-router+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix-actions-change
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cast, Android, Presentation API] Check if mApiClient is connected or connecting before using it anywhere. Some of the messages are sent by the page while the stopApplication is being executed and then mApiClient is null when we process the messages. BUG=None Committed: https://crrev.com/6bdc8b753d0ac7caec7f78ad7b558248ee0a3770 Cr-Commit-Position: refs/heads/master@{#356867}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -38 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastRouteController.java View 8 chunks +43 lines, -38 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
whywhat
PTaL
5 years, 1 month ago (2015-10-29 13:59:01 UTC) #2
mlamouri (slow - plz ping)
lgtm. I think this might fix bug 544287. Can you check?
5 years, 1 month ago (2015-10-29 15:34:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410733008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410733008/1
5 years, 1 month ago (2015-10-29 15:49:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-29 16:59:31 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 17:00:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6bdc8b753d0ac7caec7f78ad7b558248ee0a3770
Cr-Commit-Position: refs/heads/master@{#356867}

Powered by Google App Engine
This is Rietveld 408576698