Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1412293004: [Cast, Android, PresentationAPI] Show play/pause button when the presentation supports media comman… (Closed)

Created:
5 years, 1 month ago by whywhat
Modified:
5 years, 1 month ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, media-router+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix-actions-change
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cast, Android, PresentationAPI] Show play/pause button when the presentation supports media commands. Add RemoteMediaPlayer to the CastRouteController. Notify it of the media namespace messages. Use it to handle play/pause from the controls. BUG=541629 Committed: https://crrev.com/00f44574c776d9c4850c42e36c4eae8d60d9cb98 Cr-Commit-Position: refs/heads/master@{#357131}

Patch Set 1 #

Patch Set 2 : Rebased on top of a couple of bugfixes. #

Patch Set 3 : Only show play/pause when the media status is explicitly playing or paused. #

Patch Set 4 : Rebased #

Patch Set 5 : Remove "Casting to" from the notification title. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -7 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastRouteController.java View 1 2 3 4 9 chunks +46 lines, -7 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
whywhat
PTaL
5 years, 1 month ago (2015-10-29 14:02:20 UTC) #2
whywhat
Rebased
5 years, 1 month ago (2015-10-29 19:15:48 UTC) #3
mlamouri (slow - plz ping)
lgtm
5 years, 1 month ago (2015-10-30 11:38:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412293004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412293004/60001
5 years, 1 month ago (2015-10-30 11:38:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412293004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412293004/80001
5 years, 1 month ago (2015-10-30 16:52:12 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 1 month ago (2015-10-30 18:26:36 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 18:28:00 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/00f44574c776d9c4850c42e36c4eae8d60d9cb98
Cr-Commit-Position: refs/heads/master@{#357131}

Powered by Google App Engine
This is Rietveld 408576698