Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1424773002: Add ADC (immediate) instruction to ARM integrated assembler. (Closed)

Created:
5 years, 1 month ago by Karl
Modified:
5 years, 1 month ago
Reviewers:
Jim Stichnoth, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -9 lines) Patch
M src/DartARM32/assembler_arm.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/DartARM32/assembler_arm.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/IceAssemblerARM32.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 1 3 chunks +34 lines, -6 lines 0 comments Download
M src/IceInstARM32.cpp View 1 1 chunk +8 lines, -0 lines 0 comments Download
M tests_lit/assembler/arm32/add.ll View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Karl
5 years, 1 month ago (2015-10-26 20:32:40 UTC) #3
Jim Stichnoth
lgtm https://codereview.chromium.org/1424773002/diff/1/src/DartARM32/assembler_arm.h File src/DartARM32/assembler_arm.h (right): https://codereview.chromium.org/1424773002/diff/1/src/DartARM32/assembler_arm.h#newcode465 src/DartARM32/assembler_arm.h:465: // Moved to ARM32::AssemblerARM32::add() adc
5 years, 1 month ago (2015-10-26 23:42:44 UTC) #4
Karl
Committed patchset #2 (id:20001) manually as db0988808f99ee4895ea80c3e5c1b812e3d09e5b (presubmit successful).
5 years, 1 month ago (2015-10-27 14:37:03 UTC) #5
Karl
5 years, 1 month ago (2015-10-27 14:37:11 UTC) #6
Message was sent while issue was closed.
https://chromiumcodereview.appspot.com/1424773002/diff/1/src/DartARM32/assemb...
File src/DartARM32/assembler_arm.h (right):

https://chromiumcodereview.appspot.com/1424773002/diff/1/src/DartARM32/assemb...
src/DartARM32/assembler_arm.h:465: // Moved to ARM32::AssemblerARM32::add()
On 2015/10/26 23:42:44, stichnot wrote:
> adc

Done.

Powered by Google App Engine
This is Rietveld 408576698