ios: Stop using __weak.

ios: Stop using __weak.

Since we don't build with ARC enabled and without garbage collection,
__weak had no semantic meaning.  Upstream clang wants to change
__weak to have ARC zeroing weak references semantics, but to not
silently change behavior, they're first making it an error to use __weak
without ARC.  Replace __weak with comments so we can update
compilers.

Also remove a workaround that's no longer necessary.

Similar to https://codereview.chromium.org/1407103008/ on OS X.

BUG=550066, 228650
R=stuartmorgan@chromium.org
TBR=thestig

Committed: https://chromium.googlesource.com/chromium/src/+/d380128613ba8ad96b3e9c65c06d4b4fe570bf85

[Nico, 2015-11-04 21:27:04]

Description was changed from

==========
ios: Stop using __weak.

BUG=228650,550066
==========

to

==========
ios: Stop using __weak.

Since we don't build with ARC enabled and without garbage collection,
__weak had no semantic meaning.  Upstream clang wants to change
__weak to have ARC zeroing weak references semantics, but to not
silently change behavior, they're first making it an error to use __weak
without ARC.  Replace __weak with comments so we can update
compilers.

Also remove a workaround that's no longer necessary.

BUG=550066,228650
==========

[Nico, 2015-11-04 21:28:09]

Description was changed from

==========
ios: Stop using __weak.

Since we don't build with ARC enabled and without garbage collection,
__weak had no semantic meaning.  Upstream clang wants to change
__weak to have ARC zeroing weak references semantics, but to not
silently change behavior, they're first making it an error to use __weak
without ARC.  Replace __weak with comments so we can update
compilers.

Also remove a workaround that's no longer necessary.

BUG=550066,228650
==========

to

==========
ios: Stop using __weak.

Since we don't build with ARC enabled and without garbage collection,
__weak had no semantic meaning.  Upstream clang wants to change
__weak to have ARC zeroing weak references semantics, but to not
silently change behavior, they're first making it an error to use __weak
without ARC.  Replace __weak with comments so we can update
compilers.

Also remove a workaround that's no longer necessary.

Similar to https://codereview.chromium.org/1407103008/ on OS X.

BUG=550066,228650
==========

[Nico, 2015-11-04 21:28:47]

thakis@chromium.org changed reviewers:
+ stuartmorgan@chromium.org

[stuartmorgan, 2015-11-04 22:23:44]

lgtm

[Nico, 2015-11-04 22:36:24]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-11-04 22:37:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424713006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424713006/1

[Nico, 2015-11-04 22:46:34]

Description was changed from

==========
ios: Stop using __weak.

Since we don't build with ARC enabled and without garbage collection,
__weak had no semantic meaning.  Upstream clang wants to change
__weak to have ARC zeroing weak references semantics, but to not
silently change behavior, they're first making it an error to use __weak
without ARC.  Replace __weak with comments so we can update
compilers.

Also remove a workaround that's no longer necessary.

Similar to https://codereview.chromium.org/1407103008/ on OS X.

BUG=550066,228650
==========

to

==========
ios: Stop using __weak.

Since we don't build with ARC enabled and without garbage collection,
__weak had no semantic meaning.  Upstream clang wants to change
__weak to have ARC zeroing weak references semantics, but to not
silently change behavior, they're first making it an error to use __weak
without ARC.  Replace __weak with comments so we can update
compilers.

Also remove a workaround that's no longer necessary.

Similar to https://codereview.chromium.org/1407103008/ on OS X.

BUG=550066,228650
TBR=thestig
==========

[Nico, 2015-11-04 22:46:53]

thakis@chromium.org changed reviewers:
+ thestig@chromium.org

[Nico, 2015-11-04 22:46:54]

tbr thestig for components/autofill/ios/OWNERS

[commit-bot: I haz the power, 2015-11-04 22:48:46]

Patchset 1 (id:??) landed as
https://crrev.com/d380128613ba8ad96b3e9c65c06d4b4fe570bf85
Cr-Commit-Position: refs/heads/master@{#357920}

[Lei Zhang, 2015-11-04 22:49:02]

On 2015/11/04 22:46:54, Nico wrote:
> tbr thestig for components/autofill/ios/OWNERS

lgtm

[Nico, 2015-11-04 22:49:20]

Committed patchset #1 (id:1) manually as
d380128613ba8ad96b3e9c65c06d4b4fe570bf85 (presubmit successful).