Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: components/autofill/ios/browser/form_suggestion.mm

Issue 1424713006: ios: Stop using __weak. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "components/autofill/ios/browser/form_suggestion.h" 5 #import "components/autofill/ios/browser/form_suggestion.h"
6 6
7 @interface FormSuggestion () 7 @interface FormSuggestion ()
8 // TODO(rohitrao): These properties must be redefined readwrite to work around a
9 // clang bug. crbug.com/228650
10 @property(copy, readwrite) NSString* value;
11 @property(copy, readwrite) NSString* icon;
12
13 // Local initializer for a FormSuggestion. 8 // Local initializer for a FormSuggestion.
14 - (id)initWithValue:(NSString*)value 9 - (id)initWithValue:(NSString*)value
15 displayDescription:(NSString*)displayDescription 10 displayDescription:(NSString*)displayDescription
16 icon:(NSString*)icon 11 icon:(NSString*)icon
17 identifier:(NSInteger)identifier; 12 identifier:(NSInteger)identifier;
18
19 @end 13 @end
20 14
21 @implementation FormSuggestion { 15 @implementation FormSuggestion {
22 NSString* _value; 16 NSString* _value;
23 NSString* _displayDescription; 17 NSString* _displayDescription;
24 NSString* _icon; 18 NSString* _icon;
25 NSInteger _identifier; 19 NSInteger _identifier;
26 base::mac::ObjCPropertyReleaser _propertyReleaser_FormSuggestion; 20 base::mac::ObjCPropertyReleaser _propertyReleaser_FormSuggestion;
27 } 21 }
28 22
(...skipping 21 matching lines...) Expand all
50 displayDescription:(NSString*)displayDescription 44 displayDescription:(NSString*)displayDescription
51 icon:(NSString*)icon 45 icon:(NSString*)icon
52 identifier:(NSInteger)identifier { 46 identifier:(NSInteger)identifier {
53 return [[[FormSuggestion alloc] initWithValue:value 47 return [[[FormSuggestion alloc] initWithValue:value
54 displayDescription:displayDescription 48 displayDescription:displayDescription
55 icon:icon 49 icon:icon
56 identifier:identifier] autorelease]; 50 identifier:identifier] autorelease];
57 } 51 }
58 52
59 @end 53 @end
OLDNEW
« no previous file with comments | « base/ios/crb_protocol_observers_unittest.mm ('k') | ios/chrome/browser/autofill/form_suggestion_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698