components/autofill/ios/browser/form_suggestion.mm - Issue 1424713006: ios: Stop using __weak.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/ios/browser/form_suggestion.mm

Issue 1424713006: ios: Stop using __weak. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/ios/browser/form_suggestion.mm

diff --git a/components/autofill/ios/browser/form_suggestion.mm b/components/autofill/ios/browser/form_suggestion.mm

index 4f5b85a795904defb76f353bd3c6c9c123b99a55..709bb63b4ce12c0daf26ab337e54bfb943ce6234 100644

--- a/components/autofill/ios/browser/form_suggestion.mm

+++ b/components/autofill/ios/browser/form_suggestion.mm

@@ -5,17 +5,11 @@

#import "components/autofill/ios/browser/form_suggestion.h"

@interface FormSuggestion ()

-// TODO(rohitrao): These properties must be redefined readwrite to work around a

-// clang bug. crbug.com/228650

-@property(copy, readwrite) NSString* value;

-@property(copy, readwrite) NSString* icon;

// Local initializer for a FormSuggestion.

- (id)initWithValue:(NSString*)value

displayDescription:(NSString*)displayDescription

icon:(NSString*)icon

identifier:(NSInteger)identifier;

@end

@implementation FormSuggestion {