Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 14246032: RecordWriteStubs on ARM need to save FP registers (Closed)

Created:
7 years, 8 months ago by mvstanton
Modified:
7 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

RecordWriteStubs on ARM need to save FP registers A previous change erroneously stopped saving fp registers for write stubs in snapshotted code. This CL restores correct behavior, and makes sure code that saves fp registers checks at runtime for 16 or 32 fp registers. Also fix a bug in the arm simulator debugger. BUG= Committed: https://code.google.com/p/v8/source/detail?r=14359

Patch Set 1 #

Patch Set 2 : Review from Ulan #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -70 lines) Patch
M src/arm/code-stubs-arm.h View 1 1 chunk +2 lines, -22 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 3 chunks +5 lines, -16 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 7 chunks +6 lines, -14 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 3 chunks +18 lines, -17 lines 0 comments Download
M src/arm/simulator-arm.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
mvstanton
Hi guys, Here is the 1) revert of the erroneous arm fp reg change from ...
7 years, 8 months ago (2013-04-19 13:22:33 UTC) #1
mvstanton
Thanks for the good review Ulan, here are my updates.
7 years, 8 months ago (2013-04-19 15:47:38 UTC) #2
ulan
LGTM
7 years, 8 months ago (2013-04-19 15:52:42 UTC) #3
Michael Starzinger
LGTM.
7 years, 8 months ago (2013-04-19 15:53:42 UTC) #4
mvstanton
7 years, 8 months ago (2013-04-19 16:02:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r14359 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698