Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: src/arm/lithium-codegen-arm.cc

Issue 14246032: RecordWriteStubs on ARM need to save FP registers (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Review from Ulan Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/macro-assembler-arm.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm/lithium-codegen-arm.cc
diff --git a/src/arm/lithium-codegen-arm.cc b/src/arm/lithium-codegen-arm.cc
index c6ba51770331417db3b30847214692805a4708ea..a06d80454956cdebb9f44299a17993212c29002c 100644
--- a/src/arm/lithium-codegen-arm.cc
+++ b/src/arm/lithium-codegen-arm.cc
@@ -36,14 +36,6 @@ namespace v8 {
namespace internal {
-static SaveFPRegsMode GetSaveFPRegsMode() {
- // We don't need to save floating point regs when generating the snapshot
- return CpuFeatures::IsSafeForSnapshot(VFP32DREGS)
- ? kSaveFPRegs
- : kDontSaveFPRegs;
-}
-
-
class SafepointGenerator : public CallWrapper {
public:
SafepointGenerator(LCodeGen* codegen,
@@ -251,7 +243,7 @@ bool LCodeGen::GeneratePrologue() {
r0,
r3,
GetLinkRegisterState(),
- GetSaveFPRegsMode());
+ kSaveFPRegs);
}
}
Comment(";;; End allocate local context");
@@ -3080,7 +3072,7 @@ void LCodeGen::DoStoreContextSlot(LStoreContextSlot* instr) {
value,
scratch,
GetLinkRegisterState(),
- GetSaveFPRegsMode(),
+ kSaveFPRegs,
EMIT_REMEMBERED_SET,
check_needed);
}
@@ -4269,7 +4261,7 @@ void LCodeGen::DoStoreNamedField(LStoreNamedField* instr) {
scratch,
temp,
GetLinkRegisterState(),
- GetSaveFPRegsMode(),
+ kSaveFPRegs,
OMIT_REMEMBERED_SET,
OMIT_SMI_CHECK);
}
@@ -4288,7 +4280,7 @@ void LCodeGen::DoStoreNamedField(LStoreNamedField* instr) {
value,
scratch,
GetLinkRegisterState(),
- GetSaveFPRegsMode(),
+ kSaveFPRegs,
EMIT_REMEMBERED_SET,
check_needed);
}
@@ -4303,7 +4295,7 @@ void LCodeGen::DoStoreNamedField(LStoreNamedField* instr) {
value,
object,
GetLinkRegisterState(),
- GetSaveFPRegsMode(),
+ kSaveFPRegs,
EMIT_REMEMBERED_SET,
check_needed);
}
@@ -4497,7 +4489,7 @@ void LCodeGen::DoStoreKeyedFixedArray(LStoreKeyed* instr) {
key,
value,
GetLinkRegisterState(),
- GetSaveFPRegsMode(),
+ kSaveFPRegs,
EMIT_REMEMBERED_SET,
check_needed);
}
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/macro-assembler-arm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698