Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 142443006: Revert of Use GrConvexPolyEffect when clip is a single convex polygon (Closed)

Created:
6 years, 10 months ago by bsalomon
Modified:
6 years, 10 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Revert of Use GrConvexPolyEffect when clip is a single convex polygon (https://codereview.chromium.org/151523005/) Reason for revert: unit tests crashing on windows? Original issue's description: > Use GrConvexPolyEffect when clip is a single convex polygon > > BUG=skia:2051 > > Committed: http://code.google.com/p/skia/source/detail?r=13286 TBR=robertphillips@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2051 Committed: https://code.google.com/p/skia/source/detail?r=13288

Patch Set 1 #

Patch Set 2 : manual #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -31 lines) Patch
M expectations/gm/ignored-tests.txt View 1 1 chunk +1 line, -4 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 2 chunks +2 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
Created Revert of Use GrConvexPolyEffect when clip is a single convex polygon
6 years, 10 months ago (2014-02-03 20:06:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/142443006/1
6 years, 10 months ago (2014-02-03 20:06:19 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-03 20:06:22 UTC) #3
commit-bot: I haz the power
Failed to apply patch for expectations/gm/ignored-tests.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-03 20:06:22 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 20:06:28 UTC) #5
bsalomon
6 years, 10 months ago (2014-02-03 20:10:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r13288.

Powered by Google App Engine
This is Rietveld 408576698