Use GrConvexPolyEffect when clip is a single convex polygon

Use GrConvexPolyEffect when clip is a single convex polygon

BUG=skia:2051
Committed: http://code.google.com/p/skia/source/detail?r=13286

Committed: http://code.google.com/p/skia/source/detail?r=13306

[bsalomon, 2014-01-31 19:32:31]

I want to land a bench for at one cycle before this hits, but otherwise I think
it is ready.

[robertphillips, 2014-01-31 19:58:58]

lgtm + a question.

https://codereview.chromium.org/151523005/diff/100001/src/gpu/GrClipMaskManag...
File src/gpu/GrClipMaskManager.cpp (right):

https://codereview.chromium.org/151523005/diff/100001/src/gpu/GrClipMaskManag...
src/gpu/GrClipMaskManager.cpp:158: // clips against the edges.
Will inverse filled paths work correctly?

[bsalomon, 2014-01-31 20:05:32]

https://codereview.chromium.org/151523005/diff/100001/src/gpu/GrClipMaskManag...
File src/gpu/GrClipMaskManager.cpp (right):

https://codereview.chromium.org/151523005/diff/100001/src/gpu/GrClipMaskManag...
src/gpu/GrClipMaskManager.cpp:158: // clips against the edges.
On 2014/01/31 19:58:58, robertphillips wrote:
> Will inverse filled paths work correctly?

Yup, the effect factory fails.

[bsalomon, 2014-01-31 20:11:08]

On 2014/01/31 20:05:32, bsalomon wrote:
>
https://codereview.chromium.org/151523005/diff/100001/src/gpu/GrClipMaskManag...
> File src/gpu/GrClipMaskManager.cpp (right):
> 
>
https://codereview.chromium.org/151523005/diff/100001/src/gpu/GrClipMaskManag...
> src/gpu/GrClipMaskManager.cpp:158: // clips against the edges.
> On 2014/01/31 19:58:58, robertphillips wrote:
> > Will inverse filled paths work correctly?
> 
> Yup, the effect factory fails.

A modified version of the effect could work in this case, but it hasn't been
coded.

[bsalomon, 2014-02-03 19:03:15]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-02-03 19:03:24]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/151523005/100001

[commit-bot: I haz the power, 2014-02-03 19:42:45]

Change committed as 13286

[commit-bot: I haz the power, 2014-02-03 19:42:47]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-03 19:44:03]

CQ bit was unchecked on CL. Ignoring.

[bsalomon, 2014-02-03 20:06:15]

A revert of this CL has been created in
https://codereview.chromium.org/142443006/ by bsalomon@google.com.

The reason for reverting is: unit tests crashing on windows?.

[f(malita), 2014-02-03 20:11:53]

On 2014/02/03 20:06:15, bsalomon wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/142443006/ by mailto:bsalomon@google.com.
> 
> The reason for reverting is: unit tests crashing on windows?.

Also triggering 1 Win7 GM failure (possibly expected):
http://108.170.217.252:10117/builders/Test-Win7-ShuttleA-HD2000-x86_64-Debug/...

http://108.170.217.246:10117/static/view.html#/view.html?resultsToLoad=failur...

[bsalomon, 2014-02-03 20:13:41]

On 2014/02/03 20:11:53, Florin Malita wrote:
> On 2014/02/03 20:06:15, bsalomon wrote:
> > A revert of this CL has been created in
> > https://codereview.chromium.org/142443006/ by mailto:bsalomon@google.com.
> > 
> > The reason for reverting is: unit tests crashing on windows?.
> 
> Also triggering 1 Win7 GM failure (possibly expected):
>
http://108.170.217.252:10117/builders/Test-Win7-ShuttleA-HD2000-x86_64-Debug/...
> 

Yup, it's expected. I mistyped the GM name in ignored-tests as filltypes_persp
rather than filltypespersp.

[bsalomon, 2014-02-04 15:37:34]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-02-04 15:38:04]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/151523005/360001

[commit-bot: I haz the power, 2014-02-04 17:49:51]

Change committed as 13306