Chromium Code Reviews

Issue 1424213003: Add Sbc(register) and Sbc(immediate) to integrated ARM assembler. (Closed)

Created:
5 years, 1 month ago by Karl
Modified:
5 years, 1 month ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+140 lines, -19 lines)
M src/IceAssemblerARM32.h View 1 chunk +3 lines, -0 lines 0 comments
M src/IceAssemblerARM32.cpp View 1 chunk +44 lines, -0 lines 0 comments
M src/IceInstARM32.cpp View 1 chunk +8 lines, -0 lines 0 comments
M tests_lit/assembler/arm32/sub.ll View 3 chunks +85 lines, -19 lines 0 comments

Messages

Total messages: 5 (2 generated)
Karl
5 years, 1 month ago (2015-10-28 19:53:35 UTC) #3
Jim Stichnoth
lgtm
5 years, 1 month ago (2015-10-28 22:42:47 UTC) #4
Karl
5 years, 1 month ago (2015-10-29 16:11:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3b8a15ee7cd3b3587299f64315a3804edba016f7 (presubmit successful).

Powered by Google App Engine