components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlTest.java - Issue 1424193003: [Cronet] Remove CronetEngine.Builder JSON serial/deserialization APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlTest.java

Issue 1424193003: [Cronet] Remove CronetEngine.Builder JSON serial/deserialization APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address Helen's comment Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlTest.java

index 37b076233d862eb4a754cad18809b7d51e28e4be..cae73bd3041346d29ff97a336182e738fd2cf860 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlTest.java

@@ -132,14 +132,12 @@ public class CronetUrlTest extends CronetTestBase {

@SmallTest

@Feature({"Cronet"})

public void testLegacyLoadUrl() throws Exception {

- HttpUrlRequestFactoryConfig config = new HttpUrlRequestFactoryConfig();

- config.enableLegacyMode(true);

+ CronetEngine.Builder builder = new CronetEngine.Builder(getContext());

+ builder.enableLegacyMode(true);

// TODO(mef) fix tests so that library isn't loaded for legacy stack

- config.setLibraryName("cronet_tests");

- String[] commandLineArgs = {CronetTestFramework.CONFIG_KEY, config.toString()};

CronetTestFramework testFramework =

- startCronetTestFrameworkWithUrlAndCommandLineArgs(URL, commandLineArgs);

+ startCronetTestFrameworkWithUrlAndCronetEngineBuilder(URL, builder);

// Make sure that the URL is set as expected.

assertEquals(URL, testFramework.getUrl());