components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java - Issue 1424193003: [Cronet] Remove CronetEngine.Builder JSON serial/deserialization APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

Issue 1424193003: [Cronet] Remove CronetEngine.Builder JSON serial/deserialization APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address Helen's comment Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

index d9c7887ebb4519e5107c6002cdef8bda2517fed8..bdd630e01c2af6cbe8cd36d9b905469c6c29f79f 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

@@ -128,9 +128,8 @@ public class CronetUrlRequestContextTest extends CronetTestBase {

CronetEngine.Builder cronetEngineBuilder = new CronetEngine.Builder(getContext());

cronetEngineBuilder.setUserAgent(userAgentValue);

cronetEngineBuilder.setLibraryName("cronet_tests");

- String[] commandLineArgs = {CronetTestFramework.CONFIG_KEY, cronetEngineBuilder.toString()};

- mTestFramework =

- startCronetTestFrameworkWithUrlAndCommandLineArgs(TEST_URL, commandLineArgs);

+ mTestFramework = startCronetTestFrameworkWithUrlAndCronetEngineBuilder(

+ TEST_URL, cronetEngineBuilder);

assertTrue(NativeTestServer.startNativeTestServer(getContext()));

TestUrlRequestCallback callback = new TestUrlRequestCallback();

UrlRequest.Builder urlRequestBuilder =