Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java

Issue 1424193003: [Cronet] Remove CronetEngine.Builder JSON serial/deserialization APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address Helen's comment Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java
index da35bcf1d751dca6b4609afb0f4a262a35801e2a..0b59f4dbc5544892999973dbe689e791994419d7 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java
@@ -23,14 +23,13 @@ public class HttpUrlRequestFactoryTest extends CronetTestBase {
@SmallTest
@Feature({"Cronet"})
public void testCreateFactory() throws Throwable {
- HttpUrlRequestFactoryConfig config = new HttpUrlRequestFactoryConfig();
- config.enableQUIC(true);
- config.addQuicHint("www.google.com", 443, 443);
- config.addQuicHint("www.youtube.com", 443, 443);
- config.setLibraryName("cronet_tests");
- String[] commandLineArgs = {CronetTestFramework.CONFIG_KEY, config.toString()};
+ CronetEngine.Builder builder = new CronetEngine.Builder(getContext());
+ builder.enableQUIC(true);
+ builder.addQuicHint("www.google.com", 443, 443);
+ builder.addQuicHint("www.youtube.com", 443, 443);
+ builder.setLibraryName("cronet_tests");
CronetTestFramework testFramework =
- startCronetTestFrameworkWithUrlAndCommandLineArgs(URL, commandLineArgs);
+ startCronetTestFrameworkWithUrlAndCronetEngineBuilder(URL, builder);
HttpUrlRequestFactory factory = testFramework.mRequestFactory;
assertNotNull("Factory should be created", factory);
assertTrue("Factory should be Chromium/n.n.n.n@r but is "

Powered by Google App Engine
This is Rietveld 408576698