Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1423623008: Improve messages and static use for super/this-calls. (Closed)

Created:
5 years, 1 month ago by Johnni Winther
Modified:
5 years, 1 month ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve messages and static use for super/this-calls. BUG= R=sigurdm@google.com Committed: https://github.com/dart-lang/sdk/commit/e9c53271c5ae8e98acb0d4784b2f826385c59d30

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -108 lines) Patch
M pkg/compiler/lib/src/compile_time_constants.dart View 1 chunk +10 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 4 chunks +66 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 1 chunk +12 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 1 5 chunks +93 lines, -68 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 2 chunks +6 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 1 chunk +9 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/diagnose_ambiguous_test.dart View 1 chunk +10 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/message_kind_helper.dart View 5 chunks +23 lines, -14 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
Main changes in resolution/constructors.dart
5 years, 1 month ago (2015-11-09 10:16:03 UTC) #2
sigurdm
LGTM https://codereview.chromium.org/1423623008/diff/1/pkg/compiler/lib/src/resolution/constructors.dart File pkg/compiler/lib/src/resolution/constructors.dart (right): https://codereview.chromium.org/1423623008/diff/1/pkg/compiler/lib/src/resolution/constructors.dart#newcode270 pkg/compiler/lib/src/resolution/constructors.dart:270: ConstructorElement verifyThatConstructorMatchesCall( Dartdoc-comment needed explaining what is returned.
5 years, 1 month ago (2015-11-09 11:40:44 UTC) #3
Johnni Winther
https://codereview.chromium.org/1423623008/diff/1/pkg/compiler/lib/src/resolution/constructors.dart File pkg/compiler/lib/src/resolution/constructors.dart (right): https://codereview.chromium.org/1423623008/diff/1/pkg/compiler/lib/src/resolution/constructors.dart#newcode270 pkg/compiler/lib/src/resolution/constructors.dart:270: ConstructorElement verifyThatConstructorMatchesCall( On 2015/11/09 11:40:44, sigurdm wrote: > Dartdoc-comment ...
5 years, 1 month ago (2015-11-09 11:52:56 UTC) #4
Johnni Winther
5 years, 1 month ago (2015-11-09 12:24:48 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
e9c53271c5ae8e98acb0d4784b2f826385c59d30 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698