Improve messages and static use for super/this-calls.

tests/compiler/dart2js/message_kind_helper.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.test.message_kind_helper;
 
 import 'package:expect/expect.dart';
 import 'dart:async';
 
 import 'package:compiler/src/commandline_options.dart';
 import 'package:compiler/src/compiler.dart' show
     Compiler;
 import 'package:compiler/src/dart_backend/dart_backend.dart' show
     DartBackend;
 import 'package:compiler/src/diagnostics/messages.dart' show
     MessageKind,
     MessageTemplate;
-import 'package:compiler/src/old_to_new_api.dart' show
-    LegacyCompilerDiagnostics;
+import 'package:compiler/compiler_new.dart' show
+    Diagnostic;
 
 import 'memory_compiler.dart';
 
 const String ESCAPE_REGEXP = r'[[\]{}()*+?.\\^$|]';
 
 /// Most examples generate a single diagnostic.
 /// Add an exception here if a single diagnostic cannot be produced.
 /// However, consider that a single concise diagnostic is easier to understand,
 /// so try to change error reporting logic before adding an exception.
 final Set<MessageKind> kindsWithExtraMessages = new Set<MessageKind>.from([
@@ skipping 31 matching lines @@
 
   return Future.forEach(template.examples, (example) {
     if (example is String) {
       example = {'main.dart': example};
     } else {
       Expect.isTrue(example is Map,
                     "Example must be either a String or a Map.");
       Expect.isTrue(example.containsKey('main.dart'),
                     "Example map must contain a 'main.dart' entry.");
     }
-    List<String> messages = <String>[];
-    void collect(Uri uri, int begin, int end, String message, kind) {
-      if (kind.name == 'verbose info' || kind.name == 'info') {
-        return;
-      }
-      messages.add(message);
-    }
+    DiagnosticCollector collector = new DiagnosticCollector();
 
     bool oldBackendIsDart;
     if (cachedCompiler != null) {
       oldBackendIsDart = cachedCompiler.backend is DartBackend;
     }
     bool newBackendIsDart = template.options.contains('--output-type=dart');
 
     Compiler compiler = compilerFor(
         memorySourceFiles: example,
-        diagnosticHandler: new LegacyCompilerDiagnostics(collect),
+        diagnosticHandler: collector,
         options: [Flags.analyzeOnly,
                   Flags.enableExperimentalMirrors]..addAll(template.options),
         cachedCompiler:
              // TODO(johnniwinther): Remove this restriction when constant
              // values can be computed directly from the expressions.
              oldBackendIsDart == newBackendIsDart ? cachedCompiler : null);
 
     return compiler.run(Uri.parse('memory:main.dart')).then((_) {
+      Iterable<DiagnosticMessage> messages = collector.filterMessagesByKinds(
+          [Diagnostic.ERROR,
+           Diagnostic.WARNING,
+           Diagnostic.HINT,
+           Diagnostic.CRASH]);
 
       Expect.isFalse(messages.isEmpty, 'No messages in """$example"""');
 
       String expectedText = !template.hasHowToFix
           ? template.template : '${template.template}\n${template.howToFix}';
       String pattern = expectedText.replaceAllMapped(
           new RegExp(ESCAPE_REGEXP), (m) => '\\${m[0]}');
       pattern = pattern.replaceAll(new RegExp(r'#\\\{[^}]*\\\}'), '.*');
 
+      bool checkMessage(DiagnosticMessage message) {
+        if (message.message.kind != MessageKind.GENERIC) {
+          return message.message.kind == template.kind;
+        } else {
+          return new RegExp('^$pattern\$').hasMatch(message.text);
+        }
+      }
+
       // TODO(johnniwinther): Extend MessageKind to contain information on
       // where info messages are expected.
       bool messageFound = false;
       List unexpectedMessages = [];
-      for (String message in messages) {
-        if (!messageFound && new RegExp('^$pattern\$').hasMatch(message)) {
+      for (DiagnosticMessage message in messages) {
+        if (!messageFound && checkMessage(message)) {
           messageFound = true;
         } else {
           unexpectedMessages.add(message);
         }
       }
-      Expect.isTrue(messageFound, '"$pattern" does not match any in $messages');
+      Expect.isTrue(messageFound,
+          '${template.kind}} does not match any in\n '
+          '${messages.join('\n ')}');
       Expect.isFalse(compiler.reporter.hasCrashed);
       if (!unexpectedMessages.isEmpty) {
-        for (String message in unexpectedMessages) {
+        for (DiagnosticMessage message in unexpectedMessages) {
           print("Unexpected message: $message");
         }
         if (!kindsWithExtraMessages.contains(template.kind)) {
           // Try changing the error reporting logic before adding an exception
           // to [kindsWithExtraMessages].
           throw 'Unexpected messages found.';
         }
       }
 
       bool pendingStuff = false;
@@ skipping 13 matching lines @@
                     kindsWithPendingClasses.contains(template));
 
       if (!pendingStuff) {
         // If there is pending stuff, or the compiler was cancelled, we
         // shouldn't reuse the compiler.
         cachedCompiler = compiler;
       }
     });
   }).then((_) => cachedCompiler);
 }