pkg/compiler/lib/src/resolution/resolution.dart - Issue 1423623008: Improve messages and static use for super/this-calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/resolution/resolution.dart

Issue 1423623008: Improve messages and static use for super/this-calls. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comment. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/resolution/resolution.dart

diff --git a/pkg/compiler/lib/src/resolution/resolution.dart b/pkg/compiler/lib/src/resolution/resolution.dart

index 2a09e8b27865b9aeccc8aefafea63dc1ec433ec6..e59832beda25b8b5bc1cd3e1753e77c66859f70e 100644

--- a/pkg/compiler/lib/src/resolution/resolution.dart

+++ b/pkg/compiler/lib/src/resolution/resolution.dart

@@ -134,6 +134,9 @@ class ResolverTask extends CompilerTask {

while (redirection != null) {

// Ensure that we follow redirections through implementation elements.

redirection = redirection.implementation;

+ if (redirection.isError) {

+ break;

+ }

if (seen.contains(redirection)) {

reporter.reportErrorMessage(

node, MessageKind.REDIRECTING_CONSTRUCTOR_CYCLE);