Issue 1423483002: git cl try: default testfilter is no testfilter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1423483002: git cl try: default testfilter is no testfilter. (Closed)

Created:
5 years, 2 months ago by tandrii(chromium)

Modified:
5 years, 2 months ago

Reviewers:
Paweł Hajdan Jr., nodir, hinoka

CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Target Ref:
refs/heads/master

Project:
depot_tools

Visibility:
Public.

More Reviews

Description

git cl try: default testfilter is no testfilter. This removes default testfilter value ['defaulttests'] from polluting properties everywhere. This also implies that default testfilter is no testfilter or empty list, which should have equivalent meening in try recipes. R=phajdan.jr@chromium.org,nodir@chromium.org BUG=487822 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297228

Patch Set 1 #

Patch Set 2 : +luci todo #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	git_cl.py	View	1	3 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423483002/20001

5 years, 2 months ago (2015-10-21 16:37:24 UTC) #5

commit-bot: I haz the power

5 years, 2 months ago (2015-10-21 16:40:41 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297228

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages