git cl try: default testfilter is no testfilter.

git_cl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 """A git-command for integrating reviews on Rietveld."""
 
 from distutils.version import LooseVersion
@@ skipping 227 matching lines @@
     return master
   return '%s%s' % (prefix, master)
 
 
 def trigger_luci_job(changelist, masters, options):
   """Send a job to run on LUCI."""
   issue_props = changelist.GetIssueProperties()
   issue = changelist.GetIssue()
   patchset = changelist.GetMostRecentPatchset()
   for builders_and_tests in sorted(masters.itervalues()):
-    for builder in sorted(builders_and_tests.iterkeys()):
+    # TODO(hinoka et al): add support for other properties.
+    # Currently, this completely ignores testfilter and other properties.
+    for builder in sorted(builders_and_tests):
       luci_trigger.trigger(
           builder, 'HEAD', issue, patchset, issue_props['project'])
 
 
 def trigger_try_jobs(auth_config, changelist, options, masters, category):
   rietveld_url = settings.GetDefaultServerUrl()
   rietveld_host = urlparse.urlparse(rietveld_url).hostname
   authenticator = auth.get_authenticator_for_host(rietveld_host, auth_config)
   http = authenticator.authorize(httplib2.Http())
   http.force_exception_to_status_code = True
@@ skipping 26 matching lines @@
           }],
           'properties': {
               'category': category,
               'issue': issue,
               'master': master,
               'patch_project': issue_props['project'],
               'patch_storage': 'rietveld',
               'patchset': patchset,
               'reason': options.name,
               'rietveld': rietveld_url,
-              'testfilter': tests,
           },
       }
+      if tests:
+        parameters['properties']['testfilter'] = tests
       if properties:
         parameters['properties'].update(properties)
       if options.clobber:
         parameters['properties']['clobber'] = True
       batch_req_body['builds'].append(
           {
               'bucket': bucket,
               'parameters_json': json.dumps(parameters),
               'tags': ['builder:%s' % builder,
                        'buildset:%s' % buildset,
@@ skipping 2901 matching lines @@
     # multiple try masters yet.
     old_style = filter(lambda x: isinstance(x, basestring), options.bot)
     new_style = filter(lambda x: isinstance(x, tuple), options.bot)
 
     for bot in old_style:
       if ':' in bot:
         parser.error('Specifying testfilter is no longer supported')
       elif ',' in bot:
         parser.error('Specify one bot per --bot flag')
       else:
-        builders_and_tests.setdefault(bot, []).append('defaulttests')
+        builders_and_tests.setdefault(bot, [])
 
     for bot, tests in new_style:
       builders_and_tests.setdefault(bot, []).extend(tests)
 
     # Return a master map with one master to be backwards compatible. The
     # master name defaults to an empty string, which will cause the master
     # not to be set on rietveld (deprecated).
     return {options.master: builders_and_tests}
 
   masters = GetMasterMap()
@@ skipping 437 matching lines @@
 if __name__ == '__main__':
   # These affect sys.stdout so do it outside of main() to simplify mocks in
   # unit testing.
   fix_encoding.fix_encoding()
   colorama.init()
   try:
     sys.exit(main(sys.argv[1:]))
   except KeyboardInterrupt:
     sys.stderr.write('interrupted\n')
     sys.exit(1)