Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Unified Diff: git_cl.py

Issue 1423483002: git cl try: default testfilter is no testfilter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: +luci todo Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index 2f88d0b4a85579a31c0af06d831ab06042d4c513..c212300f5918403463246c5fa2f4ceb404b60c3d 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -245,7 +245,9 @@ def trigger_luci_job(changelist, masters, options):
issue = changelist.GetIssue()
patchset = changelist.GetMostRecentPatchset()
for builders_and_tests in sorted(masters.itervalues()):
- for builder in sorted(builders_and_tests.iterkeys()):
+ # TODO(hinoka et al): add support for other properties.
+ # Currently, this completely ignores testfilter and other properties.
+ for builder in sorted(builders_and_tests):
luci_trigger.trigger(
builder, 'HEAD', issue, patchset, issue_props['project'])
@@ -292,9 +294,10 @@ def trigger_try_jobs(auth_config, changelist, options, masters, category):
'patchset': patchset,
'reason': options.name,
'rietveld': rietveld_url,
- 'testfilter': tests,
},
}
+ if tests:
+ parameters['properties']['testfilter'] = tests
if properties:
parameters['properties'].update(properties)
if options.clobber:
@@ -3216,7 +3219,7 @@ def CMDtry(parser, args):
elif ',' in bot:
parser.error('Specify one bot per --bot flag')
else:
- builders_and_tests.setdefault(bot, []).append('defaulttests')
+ builders_and_tests.setdefault(bot, [])
for bot, tests in new_style:
builders_and_tests.setdefault(bot, []).extend(tests)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698