bluetooth: android: BluetoothRemoteGattCharacteristicAndroid::GetProperties()

bluetooth: android: BluetoothRemoteGattCharacteristicAndroid::GetProperties()

BUG=545682
Committed: https://crrev.com/3e992aaafae77b4e6c6fd78c77f686ff7eb11443
Cr-Commit-Position: refs/heads/master@{#356497}

[scheib, 2015-10-27 22:07:54]

scheib@chromium.org changed reviewers:
+ ortuno@chromium.org

[ortuno, 2015-10-27 22:36:21]

lgtm bar the extended properties todo

https://codereview.chromium.org/1423093003/diff/1/device/bluetooth/android/ja...
File
device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothRemoteGattCharacteristic.java
(right):

https://codereview.chromium.org/1423093003/diff/1/device/bluetooth/android/ja...
device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothRemoteGattCharacteristic.java:51:
return mCharacteristic.getProperties();
'properties' should include the extended properties (PROPERTY_RELIABLE_WRITE,
PROPERTY_WRITABLE_AUXILIARIES) [1] which getProperties() doesn't include [2[. I
don't think we need to implement them here (or soon) but, can you add a TODO and
open an issue about it?

[1]
https://webbluetoothcg.github.io/web-bluetooth/#bluetoothcharacteristicproper...
[2]
https://developer.android.com/intl/zh-cn/reference/android/bluetooth/Bluetoot...

[scheib, 2015-10-27 22:48:45]

Description was changed from

==========
bluetooth: android: Implement
BluetoothRemoteGattCharacteristicAndroid::GetProperties()

BUG=545682
==========

to

==========
bluetooth: android: BluetoothRemoteGattCharacteristicAndroid::GetProperties()

BUG=545682
==========

[scheib, 2015-10-27 23:06:16]

https://codereview.chromium.org/1423093003/diff/1/device/bluetooth/android/ja...
File
device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothRemoteGattCharacteristic.java
(right):

https://codereview.chromium.org/1423093003/diff/1/device/bluetooth/android/ja...
device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothRemoteGattCharacteristic.java:51:
return mCharacteristic.getProperties();
On 2015/10/27 22:36:21, ortuno wrote:
> 'properties' should include the extended properties (PROPERTY_RELIABLE_WRITE,
> PROPERTY_WRITABLE_AUXILIARIES) [1] which getProperties() doesn't include [2[.
I
> don't think we need to implement them here (or soon) but, can you add a TODO
and
> open an issue about it?
> 
> [1]
>
https://webbluetoothcg.github.io/web-bluetooth/#bluetoothcharacteristicproper...
> [2]
>
https://developer.android.com/intl/zh-cn/reference/android/bluetooth/Bluetoot...

Done.

[scheib, 2015-10-28 01:21:29]

The CQ bit was checked by scheib@chromium.org

[scheib, 2015-10-28 01:21:29]

The patchset sent to the CQ was uploaded after l-g-t-m from ortuno@chromium.org
Link to the patchset: https://codereview.chromium.org/1423093003/#ps40001
(title: "merge tot")

[commit-bot: I haz the power, 2015-10-28 01:22:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1423093003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1423093003/40001

[commit-bot: I haz the power, 2015-10-28 02:26:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-28 02:27:56]

Patchset 3 (id:??) landed as
https://crrev.com/3e992aaafae77b4e6c6fd78c77f686ff7eb11443
Cr-Commit-Position: refs/heads/master@{#356497}