device/bluetooth/bluetooth_gatt_service_unittest.cc - Issue 1423093003: bluetooth: android: BluetoothRemoteGattCharacteristicAndroid::GetProperties()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_gatt_service_unittest.cc

Issue 1423093003: bluetooth: android: BluetoothRemoteGattCharacteristicAndroid::GetProperties() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bta-getuuid-

Patch Set: merge tot Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/bluetooth_gatt_characteristic_unittest.cc ('k') | device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluetooth_gatt_service_unittest.cc

diff --git a/device/bluetooth/bluetooth_gatt_service_unittest.cc b/device/bluetooth/bluetooth_gatt_service_unittest.cc

index c435fba4146672bc3279e462fca1620c1eec7a72..cd8c0d8dc9c5e25d88be253f3bf6f76b77017edb 100644

--- a/device/bluetooth/bluetooth_gatt_service_unittest.cc

+++ b/device/bluetooth/bluetooth_gatt_service_unittest.cc

@@ -116,10 +116,10 @@ TEST_F(BluetoothGattServiceTest, GetCharacteristics_and_GetCharacteristic) {

std::string characteristic_uuid2 = "22222222-0000-1000-8000-00805f9b34fb";

std::string characteristic_uuid3 = characteristic_uuid2; // Duplicate UUID.

std::string characteristic_uuid4 = "33333333-0000-1000-8000-00805f9b34fb";

- SimulateGattCharacteristic(service, characteristic_uuid1);

- SimulateGattCharacteristic(service, characteristic_uuid2);

- SimulateGattCharacteristic(service, characteristic_uuid3);

- SimulateGattCharacteristic(service, characteristic_uuid4);

+ SimulateGattCharacteristic(service, characteristic_uuid1, /* properties */ 0);

+ SimulateGattCharacteristic(service, characteristic_uuid2, /* properties */ 0);

+ SimulateGattCharacteristic(service, characteristic_uuid3, /* properties */ 0);

+ SimulateGattCharacteristic(service, characteristic_uuid4, /* properties */ 0);

// Verify that GetCharacteristic can retrieve characteristics again by ID,

// and that the same Characteristics come back.