Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: components/crash/content/app/BUILD.gn

Issue 1423043002: Fix missing dependencies for //components/crash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge to #356384, update w/ review feedback Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/crash.gypi ('k') | components/crash/content/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/crash/content/app/BUILD.gn
diff --git a/components/crash/content/app/BUILD.gn b/components/crash/content/app/BUILD.gn
index b593f40a3f6cdc14af5870e059a6bd4213d98a73..482efab2acc5392380c7136ff9edaed9b4c77c48 100644
--- a/components/crash/content/app/BUILD.gn
+++ b/components/crash/content/app/BUILD.gn
@@ -15,12 +15,12 @@ source_set("lib") {
]
include_dirs = [ "../../../../breakpad/src" ]
+
+ deps = [
+ "//base",
+ ]
}
-# Note: if you depend on this target, you need to either link in
-# content.gyp:content_common, or add content/public/common/content_switches.cc
-# to your sources.
-#
# GYP version: components/crash.gypi:crash_component
source_set("app") {
sources = [
@@ -63,7 +63,10 @@ source_set("app") {
# all platforms, or preferably, depend on crash_component to get Breakpad
# everywhere except for Mac, where you will get Crashpad.
source_set("app_non_mac") {
- visibility = [ ":*" ]
+ visibility = [
+ ":*",
+ "//components/crash/content/browser",
Dirk Pranke 2015/10/27 21:33:58 this is needed to make `gn check` happy, since cra
+ ]
sources = [
"breakpad_linux_impl.h",
@@ -92,6 +95,7 @@ source_set("app_non_mac") {
":lib",
"//base",
"//base:base_static",
+ "//content/public/common",
]
if (is_android) {
« no previous file with comments | « components/crash.gypi ('k') | components/crash/content/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698