Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: components/crash/content/app/BUILD.gn

Issue 1423043002: Fix missing dependencies for //components/crash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge to #356384, update w/ review feedback Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/crash.gypi ('k') | components/crash/content/browser/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 if (is_android) { 5 if (is_android) {
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 } 7 }
8 8
9 source_set("lib") { 9 source_set("lib") {
10 sources = [ 10 sources = [
11 "crash_keys_win.cc", 11 "crash_keys_win.cc",
12 "crash_keys_win.h", 12 "crash_keys_win.h",
13 "crash_reporter_client.cc", 13 "crash_reporter_client.cc",
14 "crash_reporter_client.h", 14 "crash_reporter_client.h",
15 ] 15 ]
16 16
17 include_dirs = [ "../../../../breakpad/src" ] 17 include_dirs = [ "../../../../breakpad/src" ]
18
19 deps = [
20 "//base",
21 ]
18 } 22 }
19 23
20 # Note: if you depend on this target, you need to either link in
21 # content.gyp:content_common, or add content/public/common/content_switches.cc
22 # to your sources.
23 #
24 # GYP version: components/crash.gypi:crash_component 24 # GYP version: components/crash.gypi:crash_component
25 source_set("app") { 25 source_set("app") {
26 sources = [ 26 sources = [
27 "crashpad_mac.h", 27 "crashpad_mac.h",
28 "crashpad_mac.mm", 28 "crashpad_mac.mm",
29 ] 29 ]
30 30
31 defines = [ "CRASH_IMPLEMENTATION" ] 31 defines = [ "CRASH_IMPLEMENTATION" ]
32 32
33 deps = [ 33 deps = [
(...skipping 22 matching lines...) Expand all
56 # crash_component. crash_component_breakpad_mac_to_be_deleted will be 56 # crash_component. crash_component_breakpad_mac_to_be_deleted will be
57 # deleted. 57 # deleted.
58 # 58 #
59 # While this situation exists: 59 # While this situation exists:
60 # 60 #
61 # Do not depend on this target directly! Depend on 61 # Do not depend on this target directly! Depend on
62 # crash_component_breakpad_mac_to_be_deleted for old Breakpad behavior on 62 # crash_component_breakpad_mac_to_be_deleted for old Breakpad behavior on
63 # all platforms, or preferably, depend on crash_component to get Breakpad 63 # all platforms, or preferably, depend on crash_component to get Breakpad
64 # everywhere except for Mac, where you will get Crashpad. 64 # everywhere except for Mac, where you will get Crashpad.
65 source_set("app_non_mac") { 65 source_set("app_non_mac") {
66 visibility = [ ":*" ] 66 visibility = [
67 ":*",
68 "//components/crash/content/browser",
Dirk Pranke 2015/10/27 21:33:58 this is needed to make `gn check` happy, since cra
69 ]
67 70
68 sources = [ 71 sources = [
69 "breakpad_linux_impl.h", 72 "breakpad_linux_impl.h",
70 "breakpad_win.cc", 73 "breakpad_win.cc",
71 "breakpad_win.h", 74 "breakpad_win.h",
72 "hard_error_handler_win.cc", 75 "hard_error_handler_win.cc",
73 "hard_error_handler_win.h", 76 "hard_error_handler_win.h",
74 ] 77 ]
75 78
76 if (is_android) { 79 if (is_android) {
77 libs = [ "log" ] 80 libs = [ "log" ]
78 } 81 }
79 82
80 if (is_android || is_linux) { 83 if (is_android || is_linux) {
81 # Want these files on both Linux and Android. 84 # Want these files on both Linux and Android.
82 set_sources_assignment_filter([]) 85 set_sources_assignment_filter([])
83 sources += [ 86 sources += [
84 "breakpad_linux.cc", 87 "breakpad_linux.cc",
85 "breakpad_linux.h", 88 "breakpad_linux.h",
86 ] 89 ]
87 } 90 }
88 91
89 defines = [ "CRASH_IMPLEMENTATION" ] 92 defines = [ "CRASH_IMPLEMENTATION" ]
90 93
91 deps = [ 94 deps = [
92 ":lib", 95 ":lib",
93 "//base", 96 "//base",
94 "//base:base_static", 97 "//base:base_static",
98 "//content/public/common",
95 ] 99 ]
96 100
97 if (is_android) { 101 if (is_android) {
98 defines += [ "CHROME_BUILD_ID=" + android_chrome_build_id ] 102 defines += [ "CHROME_BUILD_ID=" + android_chrome_build_id ]
99 } 103 }
100 104
101 if (is_win) { 105 if (is_win) {
102 deps += [ 106 deps += [
103 "//sandbox", 107 "//sandbox",
104 "//breakpad:breakpad_handler", 108 "//breakpad:breakpad_handler",
(...skipping 25 matching lines...) Expand all
130 134
131 defines = [ "CRASH_IMPLEMENTATION" ] 135 defines = [ "CRASH_IMPLEMENTATION" ]
132 136
133 deps += [ 137 deps += [
134 "//base", 138 "//base",
135 "//base:base_static", 139 "//base:base_static",
136 "//breakpad", 140 "//breakpad",
137 ] 141 ]
138 } 142 }
139 } 143 }
OLDNEW
« no previous file with comments | « components/crash.gypi ('k') | components/crash/content/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698