Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: components/crash.gypi

Issue 1423043002: Fix missing dependencies for //components/crash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge to #356384, update w/ review feedback Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/crash.gypi
diff --git a/components/crash.gypi b/components/crash.gypi
index 9d6480ddab9d4328db02ab41f32afd773ea35d39..c151d376912eecde2b8a4ef758547637549e8784 100644
--- a/components/crash.gypi
+++ b/components/crash.gypi
@@ -141,6 +141,7 @@
'dependencies': [
'crash_component_lib',
'../base/base.gyp:base',
+ '../content/content.gyp:content_common',
],
'defines': ['CRASH_IMPLEMENTATION'],
'conditions': [
@@ -171,10 +172,6 @@
],
},
{
- # Note: if you depend on this target, you need to either link in
- # content.gyp:content_common, or add
- # content/public/common/content_switches.cc to your sources.
- #
# GN version: //components/crash/content/app
# TODO(mark): https://crbug.com/466890: merge this target with
@@ -292,9 +289,6 @@
['OS=="win" and target_arch=="ia32"', {
'targets': [
{
- # Note: if you depend on this target, you need to either link in
- # content.gyp:content_common, or add
- # content/public/common/content_switches.cc to your sources.
'target_name': 'breakpad_win64',
'type': 'static_library',
'sources': [
@@ -321,6 +315,7 @@
'../base/base.gyp:base_win64',
'../breakpad/breakpad.gyp:breakpad_handler_win64',
'../breakpad/breakpad.gyp:breakpad_sender_win64',
+ '../content/content.gyp:content_common',
'../sandbox/sandbox.gyp:sandbox_win64',
],
'configurations': {

Powered by Google App Engine
This is Rietveld 408576698