Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Unified Diff: base/android/java/src/org/chromium/base/ApkAssets.java

Issue 1422793004: Reland Reland Switch Chrome Android using v8 arch specific external data name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/gyp/package_resources.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/java/src/org/chromium/base/ApkAssets.java
diff --git a/base/android/java/src/org/chromium/base/ApkAssets.java b/base/android/java/src/org/chromium/base/ApkAssets.java
index a30054ff681b62d100596ed3383c0ab31466c538..e00be9924b4e0da679581549f83feab7663063c5 100644
--- a/base/android/java/src/org/chromium/base/ApkAssets.java
+++ b/base/android/java/src/org/chromium/base/ApkAssets.java
@@ -33,19 +33,6 @@ public class ApkAssets {
afd.getStartOffset(),
afd.getLength() };
} catch (IOException e) {
- // TODO(michaelbai): Remove dump assets once crbug.com/547235 fixed.
- try {
- String[] assets = context.getAssets().list("");
- StringBuffer sb = new StringBuffer("Dump assets(" + assets.length + "):\n");
- for (String asset : assets) {
- sb.append(asset);
- sb.append("\n");
- }
- Log.e(LOGTAG, sb.toString());
- } catch (IOException ioe) {
- Log.e(LOGTAG, "Error while list assets: " + ioe);
- }
-
Log.e(LOGTAG, "Error while loading asset " + fileName + ": " + e);
return new long[] {-1, -1, -1};
} finally {
« no previous file with comments | « no previous file | build/android/gyp/package_resources.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698