[sync] Abstract most ProfileSyncService //chrome deps

[sync] Abstract most ProfileSyncService //chrome deps

This CL abstracts most of the remaining dependencies that ProfileSyncService
has on //chrome and //content. The remaining dependencies are on code that will
either be componentized or will shortly be ripped out.

BUG=512825
TBR=rockot

Committed: https://crrev.com/d551be189f9b3d85ffaf15519ba0c85bcaebe69d
Cr-Commit-Position: refs/heads/master@{#358026}

[blundell, 2015-10-30 15:31:35]

blundell@chromium.org changed reviewers:
+ zea@chromium.org

[Nicolas Zea, 2015-10-31 00:15:34]

https://codereview.chromium.org/1422773004/diff/40001/components/sync_driver/...
File components/sync_driver/sync_client.h (right):

https://codereview.chromium.org/1422773004/diff/40001/components/sync_driver/...
components/sync_driver/sync_client.h:137: virtual base::FilePath
GetBaseDirectory() = 0;
How many of these can be plumbed into the ProfileSyncService via the
constructor? If possible, I'd prefer to have as much via the constructor as we
can, particularly if it's a static value that doesn't change at runtime.

[blundell, 2015-11-02 14:30:07]

Patchset #5 (id:80001) has been deleted

[blundell, 2015-11-02 14:57:36]

Patchset #5 (id:100001) has been deleted

[blundell, 2015-11-02 15:32:53]

Description was changed from

==========
[sync] Abstract most ProfileSyncService //chrome deps

This CL abstracts most of the remaining dependencies that ProfileSyncService
has on //chrome and //content. The remaining dependencies are on code that will
either be componentized or will shortly be ripped out.

BUG=512825
==========

to

==========
[sync] Abstract most ProfileSyncService //chrome deps

This CL abstracts most of the remaining dependencies that ProfileSyncService
has on //chrome and //content. The remaining dependencies are on code that will
either be componentized or will shortly be ripped out.

BUG=512825
==========

[blundell, 2015-11-02 16:08:36]

https://codereview.chromium.org/1422773004/diff/40001/components/sync_driver/...
File components/sync_driver/sync_client.h (right):

https://codereview.chromium.org/1422773004/diff/40001/components/sync_driver/...
components/sync_driver/sync_client.h:137: virtual base::FilePath
GetBaseDirectory() = 0;
On 2015/10/31 00:15:34, Nicolas Zea wrote:
> How many of these can be plumbed into the ProfileSyncService via the
> constructor? If possible, I'd prefer to have as much via the constructor as we
> can, particularly if it's a static value that doesn't change at runtime.

Done.

[Nicolas Zea, 2015-11-02 19:36:56]

LGTM with one change

https://codereview.chromium.org/1422773004/diff/80002/chrome/browser/sync/pro...
File chrome/browser/sync/profile_sync_service.cc (right):

https://codereview.chromium.org/1422773004/diff/80002/chrome/browser/sync/pro...
chrome/browser/sync/profile_sync_service.cc:179: net::URLRequestContextGetter*
url_request_context,
The url request context getter is actually RefCountedThreadSafe, so we should
pass and persist as such.

[blundell, 2015-11-03 12:37:32]

https://codereview.chromium.org/1422773004/diff/80002/chrome/browser/sync/pro...
File chrome/browser/sync/profile_sync_service.cc (right):

https://codereview.chromium.org/1422773004/diff/80002/chrome/browser/sync/pro...
chrome/browser/sync/profile_sync_service.cc:179: net::URLRequestContextGetter*
url_request_context,
On 2015/11/02 19:36:56, Nicolas Zea wrote:
> The url request context getter is actually RefCountedThreadSafe, so we should
> pass and persist as such.

Done.

[blundell, 2015-11-05 10:22:48]

Description was changed from

==========
[sync] Abstract most ProfileSyncService //chrome deps

This CL abstracts most of the remaining dependencies that ProfileSyncService
has on //chrome and //content. The remaining dependencies are on code that will
either be componentized or will shortly be ripped out.

BUG=512825
==========

to

==========
[sync] Abstract most ProfileSyncService //chrome deps

This CL abstracts most of the remaining dependencies that ProfileSyncService
has on //chrome and //content. The remaining dependencies are on code that will
either be componentized or will shortly be ripped out.

BUG=512825
TBR=rockot
==========

[blundell, 2015-11-05 10:22:48]

blundell@chromium.org changed reviewers:
+ rockot@chromium.org

[blundell, 2015-11-05 10:23:02]

TBR=rockot for //chrome/browser/extensions

[blundell, 2015-11-05 10:26:58]

The CQ bit was checked by blundell@chromium.org

[blundell, 2015-11-05 10:26:58]

The patchset sent to the CQ was uploaded after l-g-t-m from zea@chromium.org
Link to the patchset: https://codereview.chromium.org/1422773004/#ps190001
(title: "Rebase")

[commit-bot: I haz the power, 2015-11-05 10:27:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422773004/190001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422773004/190001

[commit-bot: I haz the power, 2015-11-05 11:21:29]

Committed patchset #9 (id:190001)

[commit-bot: I haz the power, 2015-11-05 11:22:11]

Patchset 9 (id:??) landed as
https://crrev.com/d551be189f9b3d85ffaf15519ba0c85bcaebe69d
Cr-Commit-Position: refs/heads/master@{#358026}