[sync] Componentize switches used by ProfileSyncService

[sync] Componentize switches used by ProfileSyncService

This CL componentizes switches used by ProfileSyncService and
ProfileSyncComponentsFactoryImpl into a new browser_sync component in
anticipation of componentizing those files into that component.

These switches are used by //cloud_print/service, and so are componentized into
//components/browser_sync/common to allow for that dependency without
//cloud_print/service incurring a dependency on the browser-side code (e.g.,
ProfileSyncService) once that code is componentized.

BUG=512825
TBR=jochen

Committed: https://crrev.com/373c28c6860eb22a5287a6c8eb31379d1364d5bb
Cr-Commit-Position: refs/heads/master@{#358048}

[blundell, 2015-11-02 21:38:09]

blundell@chromium.org changed reviewers:
+ vitalybuka@chromium.org, zea@chromium.org

[blundell, 2015-11-02 21:38:10]

zea@: Whole CL.
vitalybuka@: //cloudprint

[Nicolas Zea, 2015-11-02 22:25:21]

LGTM

https://codereview.chromium.org/1408003010/diff/20001/chrome/common/chrome_sw...
File chrome/common/chrome_switches.h (right):

https://codereview.chromium.org/1408003010/diff/20001/chrome/common/chrome_sw...
chrome/common/chrome_switches.h:161: extern const char
kEnableWifiCredentialSync[];
Move this one too?

[blundell, 2015-11-03 14:37:57]

https://codereview.chromium.org/1408003010/diff/20001/chrome/common/chrome_sw...
File chrome/common/chrome_switches.h (right):

https://codereview.chromium.org/1408003010/diff/20001/chrome/common/chrome_sw...
chrome/common/chrome_switches.h:161: extern const char
kEnableWifiCredentialSync[];
On 2015/11/02 22:25:20, Nicolas Zea wrote:
> Move this one too?

Done.

[Vitaly Buka (NO REVIEWS), 2015-11-03 18:12:51]

lgtm

[blundell, 2015-11-05 13:05:58]

blundell@chromium.org changed reviewers:
+ jochen@chromium.org

[blundell, 2015-11-05 13:05:59]

TBR=jochen for //chrome

[blundell, 2015-11-05 13:06:27]

On 2015/11/05 13:05:59, blundell wrote:
> TBR=jochen for //chrome

(outside of //chrome/browser/*sync*)

[blundell, 2015-11-05 13:06:43]

Description was changed from

==========
[sync] Componentize switches used by ProfileSyncService

This CL componentizes switches used by ProfileSyncService and
ProfileSyncComponentsFactoryImpl into a new browser_sync component in
anticipation of componentizing those files into that component.

These switches are used by //cloud_print/service, and so are componentized into
//components/browser_sync/common to allow for that dependency without
//cloud_print/service incurring a dependency on the browser-side code (e.g.,
ProfileSyncService) once that code is componentized.

BUG=512825
==========

to

==========
[sync] Componentize switches used by ProfileSyncService

This CL componentizes switches used by ProfileSyncService and
ProfileSyncComponentsFactoryImpl into a new browser_sync component in
anticipation of componentizing those files into that component.

These switches are used by //cloud_print/service, and so are componentized into
//components/browser_sync/common to allow for that dependency without
//cloud_print/service incurring a dependency on the browser-side code (e.g.,
ProfileSyncService) once that code is componentized.

BUG=512825
TBR=jochen
==========

[blundell, 2015-11-05 13:07:07]

The CQ bit was checked by blundell@chromium.org

[blundell, 2015-11-05 13:07:07]

The patchset sent to the CQ was uploaded after l-g-t-m from zea@chromium.org,
vitalybuka@chromium.org
Link to the patchset: https://codereview.chromium.org/1408003010/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2015-11-05 13:07:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1408003010/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1408003010/80001

[commit-bot: I haz the power, 2015-11-05 14:07:58]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-11-05 14:08:48]

Patchset 5 (id:??) landed as
https://crrev.com/373c28c6860eb22a5287a6c8eb31379d1364d5bb
Cr-Commit-Position: refs/heads/master@{#358048}