[sync] Abstract most ProfileSyncService //chrome deps

components/sync_driver/sync_client.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SYNC_DRIVER_SYNC_CLIENT_H_
 #define COMPONENTS_SYNC_DRIVER_SYNC_CLIENT_H_
 
 #include "base/callback_forward.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "base/time/time.h"
 #include "sync/internal_api/public/base/model_type.h"
 #include "sync/internal_api/public/engine/model_safe_worker.h"
 #include "sync/util/extensions_activity.h"
 
 class BookmarkUndoService;
 class PrefService;
 
 namespace autofill {
 class AutofillWebDataService;
 class AutocompleteSyncableService;
 class PersonalDataManager;
 }  // namespace autofill
 
+namespace base {
+class FilePath;
+class SequencedWorkerPool;
+class SingleThreadTaskRunner;
+}  // namespace base
+
 namespace bookmarks {
 class BookmarkModel;
 }  // namespace bookmarks
 
 namespace favicon {
 class FaviconService;
 }  // namespace favicon
 
 namespace history {
 class HistoryService;
 }  // namespace history
 
+namespace invalidation {
+class InvalidationService;
+}  // namespace invalidation
+
+namespace net {
+class URLRequestContextGetter;
+}  // namespace net
+
 namespace password_manager {
 class PasswordStore;
 }  // namespace password_manager
 
 namespace syncer {
 class SyncableService;
 }  // namespace syncer
 
 namespace sync_sessions {
 class SyncSessionsClient;
 }  // namespace sync_sessions
 
+namespace version_info {
+enum class Channel;
+}
+
 namespace sync_driver {
 
 class SyncApiComponentFactory;
 class SyncService;
 
 typedef base::Callback<void(base::Time, base::Time)> ClearBrowsingDataCallback;
 
 // Interface for clients of the Sync API to plumb through necessary dependent
 // components. This interface is purely for abstracting dependencies, and
 // should not contain any non-trivial functional logic.
@@ skipping 27 matching lines @@
   virtual ClearBrowsingDataCallback GetClearBrowsingDataCallback() = 0;
 
   // Returns a callback that will be invoked when password sync state has
   // potentially been changed.
   virtual base::Closure GetPasswordStateChangedCallback() = 0;
 
   virtual autofill::PersonalDataManager* GetPersonalDataManager() = 0;
   virtual scoped_refptr<autofill::AutofillWebDataService>
   GetWebDataService() = 0;
   virtual BookmarkUndoService* GetBookmarkUndoServiceIfExists() = 0;
+  virtual invalidation::InvalidationService* GetInvalidationService() = 0;
   virtual scoped_refptr<syncer::ExtensionsActivity> GetExtensionsActivity() = 0;
   virtual sync_sessions::SyncSessionsClient* GetSyncSessionsClient() = 0;
 
   // Returns a weak pointer to the syncable service specified by |type|.
   // Weak pointer may be unset if service is already destroyed.
   // Note: Should only be called from the model type thread.
   virtual base::WeakPtr<syncer::SyncableService> GetSyncableServiceForType(
       syncer::ModelType type) = 0;
 
   // Creates and returns a new ModelSafeWorker for the group, or null if one
   // cannot be created.
   // TODO(maxbogue): Move this inside SyncApiComponentFactory.
   virtual scoped_refptr<syncer::ModelSafeWorker> CreateModelWorkerForGroup(
       syncer::ModelSafeGroup group,
       syncer::WorkerLoopDestructionObserver* observer) = 0;
 
   // Returns the current SyncApiComponentFactory instance.
   virtual SyncApiComponentFactory* GetSyncApiComponentFactory() = 0;
 
+  // Returns the path of the base directory under which sync should store its
+  // data.
+  virtual base::FilePath GetBaseDirectory() = 0;

[Nicolas Zea, 2015/10/31 00:15:34]

How many of these can be plumbed into the ProfileSyncService via the
constructor? If possible, I'd prefer to have as much via the constructor as we
can, particularly if it's a static value that doesn't change at runtime.

[blundell, 2015/11/02 16:08:35]

Done.

+
+  // Returns the URLRequestContext in which sync should operate.
+  virtual net::URLRequestContextGetter* GetURLRequestContext() = 0;
+
+  // Returns an identifier representing this client for debugging purposes.
+  virtual std::string GetDebugIdentifier() = 0;
+
+  // Returns the channel of the embedder.
+  virtual version_info::Channel GetChannel() = 0;
+
+  // Accessors for threads.
+  virtual scoped_refptr<base::SingleThreadTaskRunner> GetDBThread() = 0;
+  virtual scoped_refptr<base::SingleThreadTaskRunner> GetFileThread() = 0;
+  virtual base::SequencedWorkerPool* GetBlockingPool() = 0;
+
  private:
   DISALLOW_COPY_AND_ASSIGN(SyncClient);
 };
 
 }  // namespace sync_driver
 
 #endif  // COMPONENTS_SYNC_DRIVER_SYNC_CLIENT_H_