Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1422703003: [DevTools] Use ListWidget for rendering of EditFileSystemView. (Closed)

Created:
5 years, 1 month ago by dgozman
Modified:
5 years, 1 month ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, yurys, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, lushnikov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Use ListWidget for rendering of EditFileSystemView. BUG=547664, 543426, 546882 Committed: https://crrev.com/ac5d36bf9f2b293f03347ac19692b2c956316d78 Cr-Commit-Position: refs/heads/master@{#356165}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+332 lines, -415 lines) Patch
M third_party/WebKit/Source/devtools/devtools.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js View 4 chunks +13 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/EditFileSystemView.js View 2 chunks +204 lines, -275 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxSettingsTab.js View 3 chunks +18 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js View 3 chunks +18 lines, -26 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/settings/editFileSystemView.css View 2 chunks +36 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/frameworkBlackboxSettingsTab.css View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/module.json View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/settingsScreen.css View 2 chunks +21 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js View 5 chunks +16 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/listWidget.css View 2 chunks +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1412703005 Patch 1

Messages

Total messages: 7 (2 generated)
dgozman
Take a look please.
5 years, 1 month ago (2015-10-26 21:33:43 UTC) #2
pfeldman
lgtm
5 years, 1 month ago (2015-10-26 21:39:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422703003/1
5 years, 1 month ago (2015-10-26 21:40:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 23:07:01 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 23:08:05 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ac5d36bf9f2b293f03347ac19692b2c956316d78
Cr-Commit-Position: refs/heads/master@{#356165}

Powered by Google App Engine
This is Rietveld 408576698