Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js

Issue 1422703003: [DevTools] Use ListWidget for rendering of EditFileSystemView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js
diff --git a/third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js b/third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js
index f055d0595f3e3cfea023734c7f362654d3e6024c..25fe901b947f0db100bcb2cdbf44a0eb52085120 100644
--- a/third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js
+++ b/third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js
@@ -172,15 +172,16 @@ WebInspector.NetworkConditionsSettingsTab.prototype = {
_addButtonClicked: function()
{
- this._list.addNewItem(this._customSetting.get().length);
+ this._list.addNewItem(this._customSetting.get().length, {title: "", value: {throughput: 0, latency: 0}});
},
/**
* @override
* @param {*} item
+ * @param {boolean} editable
* @return {!Element}
*/
- renderItem: function(item)
+ renderItem: function(item, editable)
{
var conditions = /** @type {!WebInspector.NetworkConditionsProfile} */ (item);
var element = createElementWithClass("div", "conditions-list-item");
@@ -197,9 +198,10 @@ WebInspector.NetworkConditionsSettingsTab.prototype = {
/**
* @override
+ * @param {*} item
* @param {number} index
*/
- removeItemRequested: function(index)
+ removeItemRequested: function(item, index)
{
var list = this._customSetting.get();
list.splice(index, 1);
@@ -211,15 +213,13 @@ WebInspector.NetworkConditionsSettingsTab.prototype = {
/**
* @override
- * @param {*|null} item
+ * @param {*} item
* @param {!WebInspector.ListWidget.Editor} editor
+ * @param {boolean} isNew
*/
- commitEdit: function(item, editor)
+ commitEdit: function(item, editor, isNew)
{
var conditions = /** @type {?WebInspector.NetworkConditionsProfile} */ (item);
- if (!conditions)
- conditions = {title: "", value: {throughput: 0, latency: 0}};
-
conditions.title = editor.control("title").value.trim();
var throughput = editor.control("throughput").value.trim();
conditions.value.throughput = throughput ? parseInt(throughput, 10) * (1024 / 8) : -1;
@@ -227,29 +227,23 @@ WebInspector.NetworkConditionsSettingsTab.prototype = {
conditions.value.latency = latency ? parseInt(latency, 10) : 0;
var list = this._customSetting.get();
- if (!item)
+ if (isNew)
list.push(conditions);
this._customSetting.set(list);
},
/**
* @override
- * @param {*|null} item
+ * @param {*} item
* @return {!WebInspector.ListWidget.Editor}
*/
beginEdit: function(item)
{
var conditions = /** @type {?WebInspector.NetworkConditionsProfile} */ (item);
var editor = this._createEditor();
- if (conditions) {
- editor.control("title").value = conditions.title;
- editor.control("throughput").value = conditions.value.throughput < 0 ? "" : String(conditions.value.throughput / (1024 / 8));
- editor.control("latency").value = String(conditions.value.latency);
- } else {
- editor.control("title").value = "";
- editor.control("throughput").value = "";
- editor.control("latency").value = "";
- }
+ editor.control("title").value = conditions.title;
+ editor.control("throughput").value = conditions.value.throughput < 0 ? "" : String(conditions.value.throughput / (1024 / 8));
+ editor.control("latency").value = String(conditions.value.latency);
return editor;
},

Powered by Google App Engine
This is Rietveld 408576698