Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1412703005: [DevTools] Remove WebInspector.SettingsList. (Closed)

Created:
5 years, 1 month ago by dgozman
Modified:
5 years, 1 month ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, yurys, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, lushnikov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@edit-file-system-list-widget
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove WebInspector.SettingsList. BUG=none Committed: https://crrev.com/fce2f324bacec5eabb6d0d2bde8b2894821d55ef Cr-Commit-Position: refs/heads/master@{#356205}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -675 lines) Patch
M third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js View 2 chunks +0 lines, -494 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/settingsScreen.css View 2 chunks +0 lines, -181 lines 0 comments Download

Depends on Patchset:

Issue 1422703003 Patch 1

Messages

Total messages: 11 (4 generated)
dgozman
Take a look please.
5 years, 1 month ago (2015-10-26 21:41:34 UTC) #2
pfeldman
👍lgtm👍
5 years, 1 month ago (2015-10-26 21:43:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412703005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412703005/1
5 years, 1 month ago (2015-10-26 23:41:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/122164)
5 years, 1 month ago (2015-10-27 00:49:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412703005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412703005/1
5 years, 1 month ago (2015-10-27 01:04:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-27 02:34:51 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 02:35:34 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fce2f324bacec5eabb6d0d2bde8b2894821d55ef
Cr-Commit-Position: refs/heads/master@{#356205}

Powered by Google App Engine
This is Rietveld 408576698